Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promisifying this module #14

Open
dsernst opened this issue Jul 31, 2015 · 3 comments
Open

Promisifying this module #14

dsernst opened this issue Jul 31, 2015 · 3 comments

Comments

@dsernst
Copy link

dsernst commented Jul 31, 2015

SInce geocoder.geocode() takes a callback as its second to last argument, I found this module to be more difficult than usual to promisify using something like bluebird's promisifyAll() function.

Have you ever tried this? Do you have any tips?

@jontewks
Copy link

Imagine seeing you here @dsernst because I came for this reason.

@troy0820
Copy link

I've done it, just so I can use the .then instead of the callback signature. Performance seems to be the same. Here is a project I used it in https://github.com/troy0820/fixit/blob/master/request-promise.js

@niftytushar
Copy link

I've updated the code to now use promises.
Refer #16
https://github.com/niftytushar/geocoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants