Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I did not find any relevant statements about the DesktopCapture API in the declaration file, which is part of the Google Extension API #680

Closed
message163 opened this issue May 30, 2024 · 4 comments

Comments

@message163
Copy link

Describe the bug

I did not find any relevant statements about the DesktopCapture API in the declaration file, which is part of the Google Extension API

To Reproduce

browser.desktopCapture.chooseDesktopMedia(["window","screen","tab"],tab, (streamId:string) => {
console.log(streamId)
})

image

@message163 message163 added the pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug label May 30, 2024
@aklinker1
Copy link
Collaborator

This is a non-standard API only chrome supports, so it is not typed. I'm considering adding types for these anyways, but haven't yet because the goal of WXT is to promote cross-browser development.

@message163
Copy link
Author

If allowed, I can contribute this part of the declaration code

@aklinker1
Copy link
Collaborator

@message163 please do! Might be hard because of the way @types/webextension-polyfill and @types/chrome use namespaces... But ideally we just add any types we need from @types/chrome into the existing AugmentedBrowser types.

https://github.com/wxt-dev/wxt/blob/main/packages%2Fwxt%2Fsrc%2Fbrowser.ts#L6-L9

@aklinker1 aklinker1 added feature contribution welcome and removed pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug labels May 31, 2024
@aklinker1
Copy link
Collaborator

aklinker1 commented Jul 27, 2024

Just released an experiment feature in [email protected] to switch to @types/chrome, which has this type in it. Try it out and let me know how it goes: #868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants