Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit fails both stores #1124

Open
5 tasks done
consciousweb opened this issue Oct 29, 2024 · 5 comments
Open
5 tasks done

Submit fails both stores #1124

consciousweb opened this issue Oct 29, 2024 · 5 comments
Labels
bug Something isn't working needs-reproduction The issue doesn't include a minimal reproduction for maintainers to use to solve the issue.

Comments

@consciousweb
Copy link

consciousweb commented Oct 29, 2024

Describe the bug

trying to use submit, and submission fails both stores. I have init both and have a .env.submit

Chrome: fails for unknown reason

Firefox: fails because it requires a string for config.manifest.content_security_policy instead of an array like Chrome v3. I used the -c param with zip and a custom firefox config and it submit correctly. Is there some way WXT has built in to handle this compatibility issue more smoothly that I'm missing?

Cli Command:

wxt submit \          
  --chrome-zip .output/[package]-[version]-chrome.zip \
  --firefox-zip .output/[package]-[version]-firefox.zip --firefox-sources-zip .output/[package]-[version]-sources.zip \

Logs:

ℹ Publishing Extension                                                                                     12:05:41 PM
✖ [PUT] "https://www.googleapis.com/upload/chromewebstore/v1.1/items/[chrome id]": 403 Forbidden
✖ [POST] "https://addons.mozilla.org/api/v5/addons/addon/[firefox id]/versions/": 400
  Bad Request

Request: https://www.googleapis.com/upload/chromewebstore/v1.1/items/[chrome id]
Response: {
  "_data": {
    "error": {
      "code": 403,
      "message": "Forbidden",
      "errors": [
        {
          "message": "Forbidden",
          "domain": "global",
          "reason": "forbidden"
        }
      ]
    }
  }
}
[12:05:41 PM]  ERROR  [PUT] "https://www.googleapis.com/upload/chromewebstore/v1.1/items/[id]": 403 Forbidden

  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async $fetch2 (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/ofetch/dist/shared/ofetch.d8adb063.cjs:322:15)
  at async CwsApi.uploadZip (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/publish-browser-extension/dist/cli.cjs:2920:5)
  at async ChromeWebStore.submit (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/publish-browser-extension/dist/cli.cjs:3010:5)
  at async Task.task [as taskFn] (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/publish-browser-extension/dist/cli.cjs:3511:11)
  at async Task.run (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/listr2/dist/index.cjs:2143:11)
Request: https://addons.mozilla.org/api/v5/addons/addon/[firefox id]/versions/
Response: {
  "_data": {
    "upload": [
      "Upload is not valid."
    ]
  }
}
[12:06:14 PM]  ERROR  [POST] "https://addons.mozilla.org/api/v5/addons/addon/[firefox id]/versions/": 400 Bad Request

  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async $fetch2 (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/ofetch/dist/shared/ofetch.d8adb063.cjs:322:15)
  at async AddonsApi.versionCreate (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/publish-browser-extension/dist/cli.cjs:3262:12)
  at async FirefoxAddonStore.submit (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/publish-browser-extension/dist/cli.cjs:3333:22)
  at async Task.task [as taskFn] (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/publish-browser-extension/dist/cli.cjs:3511:11)
  at async Task.run (/Users/[user]/.nvm/versions/node/v20.9.0/lib/node_modules/wxt/node_modules/listr2/dist/index.cjs:2143:11)

 ERROR  Submissions failed: 2      

Reproduction

n/a

Steps to reproduce

No response

System Info

System:
    OS: macOS 12.6.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 79.53 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.9.0/bin/yarn
    npm: 10.5.1 - ~/.nvm/versions/node/v20.9.0/bin/npm
    Watchman: 2023.09.04.00 - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 130.0.6723.70
    Firefox: 131.0.3
    Safari: 15.6.1
  npmPackages:
    wxt: ^0.19.9 => 0.19.9

Used Package Manager

npm

Validations

@consciousweb consciousweb added the pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug label Oct 29, 2024
@aklinker1
Copy link
Collaborator

For chrome, did you create a refresh token using wxt submit init?

For Firefox, I think there's a bug where WXT doesn't automatically convert MV3 content_security_policy to it's MV2 form.

@consciousweb
Copy link
Author

consciousweb commented Oct 31, 2024 via email

@aklinker1
Copy link
Collaborator

Are you using the right extension ID? Does a dry run pass? wxt submit --dry-run. Works fine for me, so something has to be wrong with your credentials. Did you create the gcp credentials in the same account that has access to the CWS?

@consciousweb
Copy link
Author

consciousweb commented Nov 13, 2024 via email

@aklinker1 aklinker1 added bug Something isn't working needs-reproduction The issue doesn't include a minimal reproduction for maintainers to use to solve the issue. and removed pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug labels Nov 14, 2024
@Timeraa
Copy link
Contributor

Timeraa commented Nov 17, 2024

Does it work if you upload them yourself? I had an issue once with Firefox's validation that publish didn't show for some bizzare reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-reproduction The issue doesn't include a minimal reproduction for maintainers to use to solve the issue.
Projects
None yet
Development

No branches or pull requests

3 participants