-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Logout Behavior and Session Management #474
Comments
PR #483 resolves part of this, but the issue with logging in to the wrong user is slightly different. The cause is that after successfully logging in and unlocking the keystore, this code runs to update the cached users (to copy the wallet-frontend/src/services/LocalStorageKeystore.ts Lines 118 to 134 in 6e8ebfe
But when there are two tabs open simultaneously, that code runs simultaneously in both tabs, and the |
This issue was fixed in PR #488. |
Currently, the logout function in SessionContext is called on user logout. However, in certain cases, such as:
The SessionStorage from
api/index.ts
is not cleaned up, leading to potential issues.Additionally, it would be beneficial to set
sessionStorage.setItem('freshLogin', 'true')
; during the logout process. This ensures any login/signup from each logout tab will be login with clean urlThe text was updated successfully, but these errors were encountered: