Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to run final two steps in WRStat run on files produced in a partial run. #89

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Add script to run final two steps in WRStat run on files produced in a partial run. #89

merged 4 commits into from
Sep 9, 2024

Conversation

mjkw31
Copy link
Collaborator

@mjkw31 mjkw31 commented Sep 4, 2024

No description provided.

@mjkw31 mjkw31 requested a review from sb10 September 4, 2024 08:55
sb10
sb10 requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@sb10 sb10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a new sub-command in the cmd pkg writing in go.
Or perhaps, inline with wrstat multi --partial_dir_merge, it should be a new --partial_dir_finish option to multi.

@mjkw31 mjkw31 force-pushed the feat/completion_script branch from 2044046 to 7a593cb Compare September 6, 2024 08:14
sb10
sb10 requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@sb10 sb10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need resolving and the new tests will need expectations updated to include abs path to app.

@mjkw31 mjkw31 force-pushed the feat/completion_script branch from 7a593cb to 30e7474 Compare September 6, 2024 08:47
@mjkw31
Copy link
Collaborator Author

mjkw31 commented Sep 6, 2024

Conflicts need resolving and the new tests will need expectations updated to include abs path to app.

Rebase complete.

@sb10 sb10 merged commit 92ae9ae into develop Sep 9, 2024
2 checks passed
@sb10 sb10 deleted the feat/completion_script branch September 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb10 sb10 sb10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkw31 @sb10