Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update widget iframes to use dynamic heights #6

Open
wrux opened this issue Dec 1, 2022 · 0 comments
Open

Update widget iframes to use dynamic heights #6

wrux opened this issue Dec 1, 2022 · 0 comments
Assignees
@wrux

Comments

@wrux
Copy link
Owner

wrux commented Dec 1, 2022 •
edited
Loading

Problem

Currently iframes use magic numbers for the height, meaning it will never be the correct height.

As it's an external iframe, it's not possible to access the inner content as it will result in a CORS issue.

Solution

  • Create feature requests / PRs to send a postMessage of the page height so that iframes can listen to the value.
  • Add Plausible embed script: <script async src="https://plausible.io/js/embed.host.js"></script>
@wrux wrux self-assigned this Dec 1, 2022
@wrux wrux closed this as completed Sep 6, 2023
@wrux wrux reopened this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wrux wrux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wrux