feat(Queue): Add ability to dispatch job in testable way #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4kuna
reviewed
Feb 27, 2024
src/Queue/Concerns/UsesCommand.php
Outdated
| { | ||
| private ?Command $command = null; | ||
|
|
||
| public function setCommand(?Command $command): void |
There was a problem hiding this comment.
Chceš mít možnost resetovat command? pokud ne odebral bych otazník
There was a problem hiding this comment.
dobrý point, určitě bude zbytečné
| public function execute( | ||
| Job $job, | ||
| ?Command $command = null, | ||
| Closure $setupBeforeRun = null, |
There was a problem hiding this comment.
Tady bych otazník přidal, kvůli pozičnímu zadávání parametrů.
| */ | ||
| interface UsesCommandInterface | ||
| { | ||
| public function setCommand(?Command $command): void; |
| static fn () => Assert::assertEquals( | ||
| expected: 'Test', | ||
| actual: self | ||
| ::makeAction( |
There was a problem hiding this comment.
self
::makeAction()
je žádoucí?
There was a problem hiding this comment.
jsem si nevšiml, to mě musel ecs/rector zformátovat, původně to bylo na zarovnané pěkně s ->, očividně to umí jenom když je $this
pokud bych měl pěkně $this tak to bude vypadat hezky takto se mi to nedaří hezky zarovnat.
Pohrál jsem si stím, není to co bych chtěl ale je to dostačující
|
@h4kuna Pusnuto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.