Merge remote-tracking branch 'origin/main' into fix-actions

wrbl606 · Nov 8, 2024 · 67d593c · 67d593c
2 parents df7ab1f + ffb67a5
commit 67d593c
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,10 @@
-# 5.0.0
+## 5.0.1
+
+* Avoid excessive `hasSystemFeature` calls
+
+Thanks [@yoer](https://github.com/yoer)!
+
+## 5.0.0
 
 * *BREAKING* Switch to declarative Gradle plugin setup
 * Add switching animation to `PiPSwitcher`

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -63,7 +63,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "5.0.0"
+    version: "5.0.1"
   flutter:
     dependency: "direct main"
     description: flutter

diff --git a/lib/src/floating.dart b/lib/src/floating.dart
@@ -30,11 +30,19 @@ class Floating {
 
   Timer? _timer;
   Stream<PiPStatus>? _stream;
-
   bool? _isPipAvailable;
 
   static final _singleton = Floating._internal();
 
+  @visibleForTesting
+  void reset() {
+    lastEnableArguments = null;
+    _timer?.cancel();
+    _timer = null;
+    _stream = null;
+    _isPipAvailable = null;
+  }
+
   /// Facilities Floating singleton access.
   ///
   /// PiP settings are global anyway, no point of making this instanceable.

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: floating
 description: Picture in Picture mode management for Flutter. Available only for Android.
-version: 5.0.0
+version: 5.0.1
 homepage: https://github.com/wrbl606/floating
 screenshots:
   - description: 'This screenshot shows the transformation from a full-screen application to a movable picture-in-picture form.'

diff --git a/test/src/floating_test.dart b/test/src/floating_test.dart
@@ -24,6 +24,7 @@ void main() {
   });
 
   tearDown(() {
+    Floating().reset();
     tester.setMockMethodCallHandler(channel, null);
   });
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,6 +24,7 @@ void main() { @@
       });
       tearDown(() {
+        Floating().reset();
         tester.setMockMethodCallHandler(channel, null);
       });
@@ Expand Down @@