Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron event disappears in some scenarios: _cron_comment_mail_queue_processor #194

Closed
raamdev opened this issue Dec 26, 2015 · 4 comments
Closed

Cron event disappears in some scenarios: _cron_comment_mail_queue_processor #194

raamdev opened this issue Dec 26, 2015 · 4 comments
Assignees
@raamdev
Labels
bug high priority lite pro ready for work
Milestone
v160618

Comments

@raamdev
Copy link
Contributor

raamdev commented Dec 26, 2015

This bug was originally found in the ZenCache plugin and reported in wpsharks/comet-cache#613 (comment). Comment Mail suffers from this same bug:

Here's what's happening: When wp_schedule_event() is called via wp_reschedule_event() (after ZenCache has been uninstalled: remember, this only occurs when rescheduling the event after the plugin has been uninstalled), it passes the custom every15m schedule to wp_schedule_event(), which then gets a list of schedules via wp_get_schedules() and since ZenCache has been deleted and no longer adds the custom every15m schedule via add_filter('cron_schedules', ...), the wp_schedule_event() function finds that every15m no longer exists and doesn't reschedule the _cron_zencache_auto_cache event.

Comment Mail creates and uses two (2) custom cron schedules (actually, only the every5m scheduled is used; the every15m schedule is not currently used).

So, if you ever install Comment Mail and then delete it (without disabling Data Safeguards), it's possible that the _cron_comment_mail_queue_processor cron event will get deleted and will not be recreated the next time you install Comment Mail.

The only way to ensure the _cron_comment_mail_queue_processor gets recreated is to disable Data Safeguards (Comment Mail → Config. Options → Data Safeguards), then delete the Comment Mail plugin.
@raamdev raamdev added this to the Next Release milestone Dec 26, 2015
@raamdev raamdev mentioned this issue Dec 26, 2015
Closed
@raamdev
Copy link
Contributor Author

raamdev commented Dec 26, 2015

Note that I don't believe this is related to #192 (see #192 (comment)).

@jaswrks
Copy link

jaswrks commented Dec 29, 2015

👍 Good catch. Yep, probably impacts CM too.

@raamdev raamdev self-assigned this Jan 26, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Feb 11, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release May 27, 2016
@raamdev raamdev mentioned this issue Jun 10, 2016
Closed
@raamdev raamdev modified the milestones: Next Release, Future Release Jun 10, 2016
raamdev added a commit to wpsharks/comment-mail-pro that referenced this issue Jun 10, 2016
@raamdev
Fix bug that could result in missing queue processor cron job
edea333 
See wpsharks/comment-mail#194
@raamdev raamdev mentioned this issue Jun 10, 2016
Closed
@raamdev
Copy link
Contributor Author

raamdev commented Jun 10, 2016

Next Release Changelog:

  • Bug Fix: Fixed a bug where the cron job for the Queue Processor could get deleted and never recreated, which would result in notifications getting stuck in the Mail Queue and not being sent out. If you ever installed Comment Mail and then deleted it (without first disabling Data Safeguards), and then installed Comment Mail again, you were probably affected by this issue. This release fixes the issue and makes the cron setup more robust. Props @kristineds, @renzms, @jaswsinc, and @IvanRF for help testing. See Issue #194 and Issue #173.

@raamdev raamdev closed this as completed Jun 10, 2016
raamdev added a commit that referenced this issue Jun 18, 2016
@raamdev
Phing release of v160618 with the following changes:
19dca7b 
- **Restructured Codebase**: The codebase has been completely restructured to improve performance, enhance flexibility, and make it easier to build in new features! Props @jaswsinc. See [Issue #150](#150).
- **Comment Mail Pro Upgrade Notice: Incompatible Advanced Templates.** This version of Comment Mail includes a rewritten and improved codebase. This rewrite, however, came with the unfortunate side effect of breaking backwards compatibility with Advanced Templates that were customized in a previous version of Comment Mail Pro.

     If you are currently using Comment Mail Pro and you've customized your Advanced Templates, all of your customized Advanced Templates will be backed up and the templates will then be reset to their new defaults. You will find the backup of your old customized template appended to the bottom of the new template, separated with a  <code>Legacy Template Backup</code> PHP comment. See [example screenshots](#238 (comment)).

     Note: This change has no effect on Simple templates—only Advanced Templates are affected. Advanced Templates are a Pro-only feature, so this notice only applies to Comment Mail Pro. See [Issue #238](#238).
- **Bug Fix**: Fixed a bug where `esc_html()` was being used where `esc_sql()` should've been used. Props @jaswsinc @kristineds. See [Issue #268](#268).
- **Bug Fix**: Fixed a bug that in some scenarios resulted in a "DB table creation failure" error when activating the plugin. Props @thienhaxanh2405, @PanNovak, @kristineds, and @jaswsinc. See [Issue #260](#260).
- **Bug Fix**: Fixed a bug where "New reply" notification emails were not being parsed properly by some Hotmail accounts and were showing up as blank. Props @kristineds. See [Issue #259](#259).
- **Bug Fix**: Fixed a bug that allowed spam comments to create subscriptions in Comment Mail when using Akismet. Props @IvanRF. See [Issue #250](#250).
- **Bug Fix** (Pro): When Chrome or Firefox Autofill Username/Password was enabled, the Comment Mail Pro Updater fields would incorrectly be autofilled by the browser with invalid credentials. This has been fixed. Props @renzms. [Issue #274](#274).
- **Bug Fix**: Fixed a bug where the cron job for the Queue Processor could get deleted and never recreated, which would result in notifications getting stuck in the Mail Queue and not being sent out. If you ever installed Comment Mail and then deleted it (without first disabling Data Safeguards), and then installed Comment Mail again, you were probably affected by this issue. This release fixes the issue and makes the cron setup more robust. Props @kristineds, @renzms, @jaswsinc, and @IvanRF for help testing. See [Issue #194](#194) and [Issue #173](#173).
- **Bug Fix:** Fixed a bug where a subscriber who selected Hourly Digest and who had never been notified before could, in some scenarios, have their subscription treated instead as a Weekly Digest. This bug was found and fixed during the codebase restructuring. Props @jaswsinc. See [Issue #150](#150) and additional discussion in [Issue #173](#173 (comment)).
- **Bug Fix:** Fixed a bug where in some scenarios Mail Queue entries for Digest Notifications that should have been held for sending later were not being held and were also not being sent. They also would not have shown up in the Mail Queue Event Log. This bug was found and fixed during the codebase restructuring. Props @jaswsinc. See [Issue #150](#150) and additional discussion in [Issue #173](#173 (comment)).
- **Enhancement**: Minor improvements to the Options Page menu links and positioning of the Pro Preview link. Props @renzms. See [Issue #227](#227).
- **Enhancement**: It's now possible to use the following shortcodes in the Email Footer Tag for Email Footer Templates: `[home_url]`, `[blog_name_clip]`, and `[current_host_path]`. Props @kristineds and @IvanRF. See [Issue #246](#246).
- **Enhancement**: Improved the Subscriptions meta box that appears on the Post Edit screen. For each subscription, the meta box now lists the full name and email address, the date the subscription was created, and a view link that allows you to view/edit the subscription. Props @kristineds. See [Issue #231](#231).
- **UX Enhancement (Pro)**: Improved the Dashboard notice that appears when you try to enable the Pro version of Comment Mail when the Lite version is currently enabled. Props @kristineds @jaswsinc. See [Issue #230](#230).
- **UX Enhancement**: When Subscribing Without Commenting, the Add New Subscription form now pre-populates the Name and Email address fields whenever possible. Props @kristineds. See [Issue #204](#204).
- **UI Enhancement**: Dashboard notices generated by Comment Mail now use the WordPress-style dismiss button to keep things consistent. Props @kristineds. See [Issue #193](#193).
@raamdev
Copy link
Contributor Author

raamdev commented Jun 19, 2016

Comment Mail v160618 has been released and includes changes from this GitHub Issue. See the v160618 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#194).

@wpsharks wpsharks locked and limited conversation to collaborators Jun 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@raamdev raamdev

Labels
bug high priority lite pro ready for work
Projects
None yet
Milestone
v160618
Development

No branches or pull requests
2 participants
@raamdev @jaswrks