PHP Compat Revamp #307
Merged
PHP Compat Revamp #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies
Co-authored-by: Darin Kotter <[email protected]>
Co-authored-by: Darin Kotter <[email protected]>
add back missing readme.txt file, update readme/plugin headers, refresh readme content
…o feat/phpcompat-revamp
…ist of active plugins
…r to see progress
This was
linked to
issues
Jul 25, 2022
Open
Open
|
@cadic props to all your work here, thank you! |
|
@anthonyburchell any news about a release on wp.org ? |
|
Curious to know too ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR introduces a revamp of the PHP Compat plugin, changing up how scans are done to utilize the WP Tide service instead of running scans locally. This builds off of the existing work done in the
feat/phpcompat-revampbranch.This is a major refactor that not only changes how the scanning behavior works but also refactors a lot of the existing code and structure (and also removes things that are no longer needed).
The way this now works is you go to the PHP Compatibility page and choose between either scanning your active plugins and active theme or scan all plugins and themes. You no longer choose which PHP version to scan against as the results returned will contain PHP 5.6+.
Once a scan is started, it will make individual requests to the WP Tide service with the name and version of the plugin or theme being scanned. If no results are immediately found, the request will be re-tried every 5 seconds until we get a success response. If results haven't been cached on the WP Tide side, larger plugins can sometimes take a few minutes to return results, though typically things return quickly.
We then render the results very similarly to how they currently show, showing if things are good or if there were issues. If compatibility issues are found, those issues can be viewed by clicking on the appropriate PHP version. Results can also be exported to a file.
Screenshots
Verification Process
Thorough testing should be done to ensure things still function as expected. Once the plugin is installed and active, you can go to
Tools > PHP Compatibility.From here, you can run a scan against all active plugins and the active theme or run a scan against all plugins and themes.
Trigger a scan and ensure results are shown. Ensure you can export the results and view the raw results.