Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add anchor attribute to core/paragraph block #1954

Open
jan-clockworkwp opened this issue Sep 18, 2024 · 2 comments
Open

[feat] Add anchor attribute to core/paragraph block #1954

jan-clockworkwp opened this issue Sep 18, 2024 · 2 comments
Labels
has: workaround A temporary workaround has been provided package: @faustwp/blocks Related to the Faust blocks package type: enhancement Improvements to existing functionality

Comments

@jan-clockworkwp
Copy link

Currently core/paragraph block implementation in "@faustwp/blocks": "^4.1.0" does not consider anchor attribute values. In some scenarios it can be handy to be able to set anchor to paragraph elements as well. WP core with version 6.6.1 alows for setting Anchor value to the Core Paragraph blocks.

@josephfusco josephfusco added package: @faustwp/blocks Related to the Faust blocks package type: enhancement Improvements to existing functionality labels Sep 18, 2024
@josephfusco
Copy link
Member

Hey @jan-clockworkwp, thanks for creating this issue.

Here is an example showing how to override a query of a component from @faustwp/blocks within your own codebase: #1932 (comment)

You should be able to add support for the fields that are missing until it's available in a future release of the blocks package.

@josephfusco josephfusco added the has: workaround A temporary workaround has been provided label Sep 18, 2024
@jan-clockworkwp
Copy link
Author

Hi @josephfusco, thanks for your suggestion. I did a similar Faust core block override on my end; I just thought that it should be a part of the Faustjs package, as it is a WordPress core-supported Gutenberg feature. Until it is part of the package, I have done exactly the same thing with the addition of actually updating the component-generated markup, as in the core/paragraph block from the Faust package, the id attribute on the p tag is not being considered, even if the anchor is part of the attributes. Thanks again; I appreciate your input and suggestion for a temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has: workaround A temporary workaround has been provided package: @faustwp/blocks Related to the Faust blocks package type: enhancement Improvements to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants