Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement network-specific metadata handling in commands. #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement network-specific metadata handling in commands. #518

wants to merge 1 commit into from

Conversation

spacedmonkey
Copy link

Added overrides for add, update, get, and delete metadata methods to utilize network-specific options when available. This ensures compatibility and functionality for multisite network scenarios. Fallbacks to standard metadata functions are maintained for non-network environments.

Add function exists, to ensure compatablity with 4.2 below.

Fixes #504

@jonnynews
Implement network-specific metadata handling in commands.
cad3602 
Added overrides for add, update, get, and delete metadata methods to utilize network-specific options when available. This ensures compatibility and functionality for multisite network scenarios. Fallbacks to standard metadata functions are maintained for non-network environments.
@spacedmonkey spacedmonkey requested a review from a team as a code owner January 22, 2025 01:14
@spacedmonkey spacedmonkey mentioned this pull request Jan 22, 2025
Open
2 tasks
@spacedmonkey
Copy link
Author

Pinging maintainers to get eyes on this @swissspidy @danielbachhuber @schlessera

@swissspidy
Copy link
Member

Note that we get pinged automatically with the review request :)

@swissspidy
Copy link
Member

Two thoughts:

  1. Network meta command accessing the incorrect caches #504 mentions steps to reproduce the issue — this could be added as a Behat test.
  2. Looking at https://core.trac.wordpress.org/ticket/61467, it sounds like this could just as well be fixed only in core — so why this change here? Could we just wait for the core fix?

@jonnynews
Copy link

Note that we get pinged automatically with the review request :)

No one was assigned for a code reviewers. Maybe this repo needs a codeowner file 🤔

#504 mentions steps to reproduce the issue — this could be added as a Behat test.

Before spending any time on getting tests to work, I wanted to make sure everyone was happy with the approach.

Looking at https://core.trac.wordpress.org/ticket/61467, it sounds like this could just as well be fixed only in core — so why this change here? Could we just wait for the core fix?

The core patch is not confirmed yet and not work. Also that will only fix the issue with 6.8+. WP CLI support down to 3.7. Fixing this here is to ensure BC.

@swissspidy
Copy link
Member

No one was assigned for a code reviewers.

Screenshot 2025-01-22 at 14 51 12
Screenshot 2025-01-22 at 14 51 05

Before spending any time on getting tests to work, I wanted to make sure everyone was happy with the approach.

It looks reasonable to me in theory, yes.

@jonnynews
Copy link

No one was assigned for a code reviewers.

This is what I see

Screenshot 2025-01-22 at 09 06 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network meta command accessing the incorrect caches
3 participants
@spacedmonkey @swissspidy @jonnynews