Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Make PrevStateRoot of models.Batch non-optional #605

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

max-sidorov
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #605 (02713f1) into master (f961ef4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   61.94%   61.97%   +0.03%     
==========================================
  Files         280      281       +1     
  Lines       12989    13001      +12     
==========================================
+ Hits         8046     8058      +12     
  Misses       4148     4148              
  Partials      795      795              
Flag Coverage Δ
build-test 61.96% <100.00%> (+0.01%) ⬆️
e2e-tests 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/error.go 58.13% <ø> (ø)
storage/batch.go 74.66% <100.00%> (+1.05%) ⬆️
e2e/get_domain.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f961ef4...02713f1. Read the comment docs.

@max-sidorov max-sidorov marked this pull request as ready for review February 25, 2022 15:02
@max-sidorov max-sidorov requested a review from msieczko February 25, 2022 15:02
@b-tarczynski
Copy link
Contributor

b-tarczynski commented Mar 1, 2022

PrevStateRoot is non-optional now. Could you change type of that field in models.Batch to common.Hash instead of pointer?

@max-sidorov
Copy link
Contributor Author

Yes, of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants