From eb7b97d477882359cb369e0d2b0e76d6905cb899 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Mon, 22 Oct 2018 14:05:08 -0400 Subject: [PATCH 01/21] ieddtab help : add typos to helpfile --- src/help_files/ieddtab.sthlp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/help_files/ieddtab.sthlp b/src/help_files/ieddtab.sthlp index 1987eb3e..1ee1cb1a 100644 --- a/src/help_files/ieddtab.sthlp +++ b/src/help_files/ieddtab.sthlp @@ -25,7 +25,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {cmdab:texn:otewidth(}{it:numlist}{cmd:)} {cmdab:texvspace(}{it:string}{cmd:)} ] -{pmore}Where {it:varlist} is a list of numeric continuous outcome variables (also called dependable variables or left hand variables) to be used in the difference-in-difference regression(s) this command runs and presents the results from.{p_end} +{pmore}Where {it:varlist} is a list of numeric continuous outcome variables (also called dependent variables or left hand side variables) to be used in the difference-in-difference regression(s) this command runs and presents the results from.{p_end} {marker opts}{...} {synoptset 24}{...} From e18203f26b5fcf1aed8bbc8c3d10b4dfa9a69a11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Tue, 30 Oct 2018 11:28:41 -0400 Subject: [PATCH 02/21] ieduplicates : fix #166 improve error message --- src/ado_files/ieduplicates.ado | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ado_files/ieduplicates.ado b/src/ado_files/ieduplicates.ado index 19164de4..c539b163 100644 --- a/src/ado_files/ieduplicates.ado +++ b/src/ado_files/ieduplicates.ado @@ -333,6 +333,8 @@ } *Same error for any incorrect input + + di as error "{phang}Since there was at least one error in the Excel report no corrections have been made to the duplicates in the data set. Please address the errors above and then run the command again.{p_end}" error 198 exit } From 3ef8fde09cd6ea5a02ef90f860503b73af8a721a Mon Sep 17 00:00:00 2001 From: Matteo Ruzzante Date: Wed, 31 Oct 2018 16:18:05 -0400 Subject: [PATCH 03/21] ieduplicates: fix typo in error message --- src/ado_files/ieduplicates.ado | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ado_files/ieduplicates.ado b/src/ado_files/ieduplicates.ado index c539b163..25f2f94c 100644 --- a/src/ado_files/ieduplicates.ado +++ b/src/ado_files/ieduplicates.ado @@ -167,7 +167,7 @@ *Test that the ID variable is in the imported report if `:list idvar in existingExcelVars' == 0 { - noi display as error "{phang}The ID variable `idvar' does not exist in the previously exported Excle file. If you renamed the ID variable you need to rename it manually in the Excel report or start a new Excel report by renaming or moving the original report, then run the command again and create a new file and manually copy any corrections from the old file to the new. If you changed the ID varaible you need to start with a new report.{p_end}" + noi display as error "{phang}The ID variable `idvar' does not exist in the previously exported Excle file. If you renamed the ID variable you need to rename it manually in the Excel report or start a new Excel report by renaming or moving the original report, then run the command again and create a new file and manually copy any corrections from the old file to the new. If you changed the ID variable you need to start with a new report.{p_end}" noi di "" error 111 exit @@ -615,7 +615,7 @@ levelsof newID if missing(real(newID)), local(NaN_values) clean * Output error message - di as error "{phang}The ID varaible `idvar' is numeric but newID has thes non-numeric values: `NaN_values'. Update newID to only contain numeric values or see option tostringok.{p_end}" + di as error "{phang}The ID variable `idvar' is numeric but newID has these non-numeric values: `NaN_values'. Update newID to only contain numeric values or see option tostringok.{p_end}" error 109 exit } From 2021bff1968e485ea13e790598ac794cac1e8a32 Mon Sep 17 00:00:00 2001 From: Saori Iwamoto <42242854+SaoriIwa@users.noreply.github.com> Date: Tue, 6 Nov 2018 11:57:07 -0500 Subject: [PATCH 04/21] iebaltab -fix line 22, fix broken link #168 --- src/help_files/iebaltab.sthlp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/help_files/iebaltab.sthlp b/src/help_files/iebaltab.sthlp index 0b7a6103..974a0e94 100644 --- a/src/help_files/iebaltab.sthlp +++ b/src/help_files/iebaltab.sthlp @@ -19,7 +19,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/Iebaltab":DI [ {it:{help iebaltab##columnoptions:column_options} {help iebaltab##labeloptions:label_options}} {it:{help iebaltab##statsoptions:stats_options} {help iebaltab##ftestoptions:ftest_options}} -{it: {help iebaltab##display:display_options} {help iebaltab##exportoptions:export_options}} +{it: {help iebaltab##displayoptioins:display_options} {help iebaltab##exportoptions:export_options}} ] {phang2}where {it:balancevarlist} is one or several variables (from here on called balance variables) for which the command From 49da4a57aa2da8c20c430a44e0c74787c60c5811 Mon Sep 17 00:00:00 2001 From: Benjamin Daniels Date: Wed, 7 Nov 2018 13:42:33 -0500 Subject: [PATCH 05/21] Fix weight option with backwards compatibility --- src/ado_files/iebaltab.ado | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/ado_files/iebaltab.ado b/src/ado_files/iebaltab.ado index 81a3b275..5f4aad27 100644 --- a/src/ado_files/iebaltab.ado +++ b/src/ado_files/iebaltab.ado @@ -3,7 +3,7 @@ capture program drop iebaltab program iebaltab - syntax varlist(numeric) [if] [in], /// + syntax varlist(numeric) [if] [in] [aw fw pw iw], /// /// /*Group variable*/ /// GRPVar(varname) /// @@ -82,6 +82,13 @@ qui { *Set minimum version for this command version 11 + * Backwards compatibility for weight option + if "`weight'" != "" & "`exp'" == "" { + tokenize `weight', parse(=) + local weight "`1'" + local exp = "= `3'" + } + *Remove observations excluded by if and in marksample touse, novarlist keep if `touse' @@ -692,13 +699,13 @@ qui { if `WEIGHT_USED' == 1 { * Parsing weight options - gettoken weight_type weight_var : weight, parse("=") + local weight_type = "`weight'" * Parsing keeps the separating character - local weight_var : subinstr local weight_var "=" "" + local weight_var = subinstr("`exp'","=","",.) * Test is weight type specified is valie - local weight_options "fweights pweights aweights iweights fw freq weight pw aw iw" + local weight_options "fweights pweights aweights iweights fweight pweight aweight iweight fw freq weight pw aw iw" if `:list weight_type in weight_options' == 0 { From fe6f8ecb09b37531c384861998f2035b012e86d5 Mon Sep 17 00:00:00 2001 From: Benjamin Daniels Date: Wed, 7 Nov 2018 13:44:14 -0500 Subject: [PATCH 06/21] Update weight documentation --- src/help_files/iebaltab.sthlp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/help_files/iebaltab.sthlp b/src/help_files/iebaltab.sthlp index 974a0e94..e0438756 100644 --- a/src/help_files/iebaltab.sthlp +++ b/src/help_files/iebaltab.sthlp @@ -14,7 +14,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/Iebaltab":DI {title:Syntax} {phang2} -{cmdab:iebaltab} {it:balancevarlist} [{help if:if}] [{help in:in}] +{cmdab:iebaltab} {it:balancevarlist} [{help if:if}] [{help in:in}] [{help weight}] , {cmdab:grpv:ar(}{it:varname}{cmd:)} {c -(} {cmdab:save(}{it:{help filename}}{cmd:)} | {cmdab:savet:ex(}{it:{help filename}}{cmd:)} | {cmdab:browse} {c )-} [ {it:{help iebaltab##columnoptions:column_options} {help iebaltab##labeloptions:label_options}} @@ -66,7 +66,6 @@ will test for differences across the catagories in grpvar({it:varname}). {synopt :{cmdab:covmiss:(}{it:reptype}{cmd:)}}Replaces missing values in covariate variables with either zeros, the mean or the group mean. See details on {it:reptype} below.{p_end} {synopt :{cmdab:covmissr:eg(}{it:reptype}{cmd:)}}Similar to {cmd:covmiss()} but treats {help missing:extended missing values} still as missing. See details on {it:reptype} below.{p_end} {synopt :{cmdab:missmin:mean(}{it:{help numlist:numlist}}{cmd:)}}Sets a minimum number of observations that a mean or group mean must be based on in options requiring {it:reptype}.{p_end} -{synopt :{cmdab:weight(}{it:weight_option}{cmd:)}}Determines weight variable and method. aweights, fweights, iweights, and pweights are allowed.{p_end} {marker ftestoptions}{...} {pstd}{it: F-test:}{p_end} @@ -286,9 +285,6 @@ The difference is that this option still treats {help missing:extended missing v {phang}{cmdab:missmin:mean(}{it:{help numlist:numlist}}{cmd:)} sets a minimum number of observations that a mean or group mean must be based on in {cmd:balmiss()}, {cmd:balmissreg()}, {cmd:covmiss()} and {cmd:covmissreg()}. The arbitrary default is 10.{p_end} -{phang}{cmdab:weight(}{it:weight_option}{cmd:)} defines a variable to be used as weight. {it:weight_option} is a string in the following format {it:"weight_type = weight_variable"}, where -weight_type is a Stata {help weight:weight} option, and weight_variable is a numeric variable.{p_end} - {phang}{cmdab:vce:(}{it:{help vce_option:vce_types}{cmd:)}} sets the type of variance estimator to be used in all regressions for this command. See {help vce_option:vce_types} for more details. The only vce types allowed in this command are {hi:robust}, {hi:cluster} {it:clustervar} or {hi:bootstrap}.{p_end} From c857b577c637e346febcb0871f0358471e0cf2d3 Mon Sep 17 00:00:00 2001 From: Luiza Date: Wed, 7 Nov 2018 14:45:52 -0500 Subject: [PATCH 07/21] Revert "Update weight documentation" This reverts commit fe6f8ecb09b37531c384861998f2035b012e86d5. --- src/help_files/iebaltab.sthlp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/help_files/iebaltab.sthlp b/src/help_files/iebaltab.sthlp index e0438756..974a0e94 100644 --- a/src/help_files/iebaltab.sthlp +++ b/src/help_files/iebaltab.sthlp @@ -14,7 +14,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/Iebaltab":DI {title:Syntax} {phang2} -{cmdab:iebaltab} {it:balancevarlist} [{help if:if}] [{help in:in}] [{help weight}] +{cmdab:iebaltab} {it:balancevarlist} [{help if:if}] [{help in:in}] , {cmdab:grpv:ar(}{it:varname}{cmd:)} {c -(} {cmdab:save(}{it:{help filename}}{cmd:)} | {cmdab:savet:ex(}{it:{help filename}}{cmd:)} | {cmdab:browse} {c )-} [ {it:{help iebaltab##columnoptions:column_options} {help iebaltab##labeloptions:label_options}} @@ -66,6 +66,7 @@ will test for differences across the catagories in grpvar({it:varname}). {synopt :{cmdab:covmiss:(}{it:reptype}{cmd:)}}Replaces missing values in covariate variables with either zeros, the mean or the group mean. See details on {it:reptype} below.{p_end} {synopt :{cmdab:covmissr:eg(}{it:reptype}{cmd:)}}Similar to {cmd:covmiss()} but treats {help missing:extended missing values} still as missing. See details on {it:reptype} below.{p_end} {synopt :{cmdab:missmin:mean(}{it:{help numlist:numlist}}{cmd:)}}Sets a minimum number of observations that a mean or group mean must be based on in options requiring {it:reptype}.{p_end} +{synopt :{cmdab:weight(}{it:weight_option}{cmd:)}}Determines weight variable and method. aweights, fweights, iweights, and pweights are allowed.{p_end} {marker ftestoptions}{...} {pstd}{it: F-test:}{p_end} @@ -285,6 +286,9 @@ The difference is that this option still treats {help missing:extended missing v {phang}{cmdab:missmin:mean(}{it:{help numlist:numlist}}{cmd:)} sets a minimum number of observations that a mean or group mean must be based on in {cmd:balmiss()}, {cmd:balmissreg()}, {cmd:covmiss()} and {cmd:covmissreg()}. The arbitrary default is 10.{p_end} +{phang}{cmdab:weight(}{it:weight_option}{cmd:)} defines a variable to be used as weight. {it:weight_option} is a string in the following format {it:"weight_type = weight_variable"}, where +weight_type is a Stata {help weight:weight} option, and weight_variable is a numeric variable.{p_end} + {phang}{cmdab:vce:(}{it:{help vce_option:vce_types}{cmd:)}} sets the type of variance estimator to be used in all regressions for this command. See {help vce_option:vce_types} for more details. The only vce types allowed in this command are {hi:robust}, {hi:cluster} {it:clustervar} or {hi:bootstrap}.{p_end} From 944f2a445a8ea692e91bda09bfe14fc26c3b2609 Mon Sep 17 00:00:00 2001 From: Luiza Date: Wed, 7 Nov 2018 14:46:49 -0500 Subject: [PATCH 08/21] #171 : fixed inconsistency in last fix The weight() option was overwriting the [weight] option implemented by Ben. Though his way would be the best, it would not be possible to have it AND still have backwards compatibility. When we re-write iebaltab, we should revisit this. --- src/ado_files/iebaltab.ado | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ado_files/iebaltab.ado b/src/ado_files/iebaltab.ado index 5f4aad27..d2efab50 100644 --- a/src/ado_files/iebaltab.ado +++ b/src/ado_files/iebaltab.ado @@ -3,7 +3,7 @@ capture program drop iebaltab program iebaltab - syntax varlist(numeric) [if] [in] [aw fw pw iw], /// + syntax varlist(numeric) [if] [in], /// /// /*Group variable*/ /// GRPVar(varname) /// From 83c10755422f333bead0841ed8639fee0343d170 Mon Sep 17 00:00:00 2001 From: Luiza Date: Thu, 8 Nov 2018 15:47:39 -0500 Subject: [PATCH 09/21] Revert "Revert "Update weight documentation"" This reverts commit c857b577c637e346febcb0871f0358471e0cf2d3. --- src/help_files/iebaltab.sthlp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/help_files/iebaltab.sthlp b/src/help_files/iebaltab.sthlp index 974a0e94..e0438756 100644 --- a/src/help_files/iebaltab.sthlp +++ b/src/help_files/iebaltab.sthlp @@ -14,7 +14,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/Iebaltab":DI {title:Syntax} {phang2} -{cmdab:iebaltab} {it:balancevarlist} [{help if:if}] [{help in:in}] +{cmdab:iebaltab} {it:balancevarlist} [{help if:if}] [{help in:in}] [{help weight}] , {cmdab:grpv:ar(}{it:varname}{cmd:)} {c -(} {cmdab:save(}{it:{help filename}}{cmd:)} | {cmdab:savet:ex(}{it:{help filename}}{cmd:)} | {cmdab:browse} {c )-} [ {it:{help iebaltab##columnoptions:column_options} {help iebaltab##labeloptions:label_options}} @@ -66,7 +66,6 @@ will test for differences across the catagories in grpvar({it:varname}). {synopt :{cmdab:covmiss:(}{it:reptype}{cmd:)}}Replaces missing values in covariate variables with either zeros, the mean or the group mean. See details on {it:reptype} below.{p_end} {synopt :{cmdab:covmissr:eg(}{it:reptype}{cmd:)}}Similar to {cmd:covmiss()} but treats {help missing:extended missing values} still as missing. See details on {it:reptype} below.{p_end} {synopt :{cmdab:missmin:mean(}{it:{help numlist:numlist}}{cmd:)}}Sets a minimum number of observations that a mean or group mean must be based on in options requiring {it:reptype}.{p_end} -{synopt :{cmdab:weight(}{it:weight_option}{cmd:)}}Determines weight variable and method. aweights, fweights, iweights, and pweights are allowed.{p_end} {marker ftestoptions}{...} {pstd}{it: F-test:}{p_end} @@ -286,9 +285,6 @@ The difference is that this option still treats {help missing:extended missing v {phang}{cmdab:missmin:mean(}{it:{help numlist:numlist}}{cmd:)} sets a minimum number of observations that a mean or group mean must be based on in {cmd:balmiss()}, {cmd:balmissreg()}, {cmd:covmiss()} and {cmd:covmissreg()}. The arbitrary default is 10.{p_end} -{phang}{cmdab:weight(}{it:weight_option}{cmd:)} defines a variable to be used as weight. {it:weight_option} is a string in the following format {it:"weight_type = weight_variable"}, where -weight_type is a Stata {help weight:weight} option, and weight_variable is a numeric variable.{p_end} - {phang}{cmdab:vce:(}{it:{help vce_option:vce_types}{cmd:)}} sets the type of variance estimator to be used in all regressions for this command. See {help vce_option:vce_types} for more details. The only vce types allowed in this command are {hi:robust}, {hi:cluster} {it:clustervar} or {hi:bootstrap}.{p_end} From 6e04e888d4c7ec4cb05d608bde22980e5f4af641 Mon Sep 17 00:00:00 2001 From: Luiza Date: Thu, 8 Nov 2018 16:16:19 -0500 Subject: [PATCH 10/21] #171 : now with proper weight option and backward compatibility Just implementing what Ben first suggested, but calling the old weight option is now called weightold, abbreviating as weight to keep backwards compatibility --- src/ado_files/iebaltab.ado | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ado_files/iebaltab.ado b/src/ado_files/iebaltab.ado index d2efab50..d6506c05 100644 --- a/src/ado_files/iebaltab.ado +++ b/src/ado_files/iebaltab.ado @@ -3,7 +3,7 @@ capture program drop iebaltab program iebaltab - syntax varlist(numeric) [if] [in], /// + syntax varlist(numeric) [if] [in] [aw fw pw iw], /// /// /*Group variable*/ /// GRPVar(varname) /// @@ -33,7 +33,7 @@ COVMISS(string) /// COVMISSReg(string) /// MISSMINmean(numlist min=1 max=1 >0) /// - weight(string) /// + WEIGHTold(string) /// /// /*F-test*/ /// FTest /// @@ -83,13 +83,13 @@ qui { version 11 * Backwards compatibility for weight option - if "`weight'" != "" & "`exp'" == "" { - tokenize `weight', parse(=) + if "`weightold'" != "" & "`exp'" == "" { + tokenize `weightold', parse(=) local weight "`1'" local exp = "= `3'" } - *Remove observations excluded by if and in + *Remove observations excluded by if and in marksample touse, novarlist keep if `touse' From 40686f69b265156f3ac985d5e49b34d0dde3e847 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Thu, 8 Nov 2018 17:53:51 -0500 Subject: [PATCH 11/21] ieddtab : add option stardrop #165 --- src/ado_files/ieddtab.ado | 39 ++++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index 10bbfb71..50b68526 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -13,6 +13,7 @@ cap program drop ieddtab /// /* Output display */ /// STARLevels(numlist descending min=3 max=3 >0 <1) /// + stardrop /// ROWLabtype(string) /// rowlabtext(string) /// ERRortype(string) /// @@ -274,7 +275,7 @@ cap program drop ieddtab *Get the number of stars using sub-command countStars local ++colindex local pvalue = el(resTable,4,3) - countStars `pvalue' `starlevels' + countStars `pvalue' `starlevels' `stardrop' mat `var'[1,`colindex'] = `r(stars)' *Get the N of second difference regression @@ -312,7 +313,7 @@ cap program drop ieddtab *Get the number of stars using sub-command countStars local ++colindex local pvalue = el(resTable,4,1) - countStars `pvalue' `starlevels' + countStars `pvalue' `starlevels' `stardrop' mat `var'[1,`colindex'] = `r(stars)' *Get the N of first difference regression @@ -405,11 +406,13 @@ cap program drop ieddtab local note_obs "The baseline means only include observations not omitted in the 1st and 2nd differences. The number of observations in the 1st and 2nd differences includes both baseline and follow-up observations." - *Show stars levels - local star1_value : word 1 of `starlevels' - local star2_value : word 2 of `starlevels' - local star3_value : word 3 of `starlevels' - local note_stars "***, **, and * indicate significance at the `star3_value', `star2_value', and `star1_value' percent critical level." + *Only include note on stars levels if stardrop was NOT used + if "`stardrop'" == "" { + local star1_value : word 1 of `starlevels' + local star2_value : word 2 of `starlevels' + local star3_value : word 3 of `starlevels' + local note_stars "***, **, and * indicate significance at the `star3_value', `star2_value', and `star1_value' percent critical level." + } *Only include note on covariates if covariates were used if "`covariates'" != "" { @@ -454,7 +457,7 @@ cap program drop ieddtab *************/ outputwindow `varlist' , ddtab_resultMap(ddtab_resultMap) labmaxlen(`labmaxlen') rwlbls(`rowlabels') /// - starlevels("`starlevels'") covariates(`covariates') `errortype' format(`format') note(`note') `cluster' + `errortype' format(`format') note(`note') `cluster' /************* @@ -466,7 +469,7 @@ cap program drop ieddtab outputtex `varlist', ddtab_resultMap(ddtab_resultMap) /// savetex(`savetex') `replace' /// `texdocument' texcaption("`texcaption'") texlabel("`texlabel'") texnotewidth(`texnotewidth') /// - `onerow' starlevels("`starlevels'") format(`format') rwlbls("`rowlabels'") errortype(`errortype') /// + `onerow' format(`format') rwlbls("`rowlabels'") errortype(`errortype') /// note(`note') texvspace("`texvspace'") `cluster' } @@ -673,12 +676,16 @@ end cap program drop countStars program define countStars, rclass - args pvalue star1 star2 star3 + args pvalue star1 star2 star3 stardrop local stars 0 - foreach star_p_level in `star1' `star2' `star3' { - if `pvalue' < `star_p_level' local ++stars + *Option to suppress all stars + if "`stardrop'" == "" { + foreach star_p_level in `star1' `star2' `star3' { + + if `pvalue' < `star_p_level' local ++stars + } } return local stars `stars' @@ -833,8 +840,8 @@ end cap program drop outputwindow program define outputwindow - syntax varlist , ddtab_resultMap(name) labmaxlen(numlist) rwlbls(string) starlevels(string) format(string) /// - [covariates(string) errhide sd se note(string) cluster] + syntax varlist , ddtab_resultMap(name) labmaxlen(numlist) rwlbls(string) format(string) /// + [errhide sd se note(string) cluster] *Prepare lables for the erorrs to be displayed (in case any) if "`sd'" != "" local errlabel "SD" @@ -977,8 +984,6 @@ end ************************* * Write notes below the table - - *List covariates used if (`"`note'"' != "") { noi di as text `"{pstd}`note'{p_end}"' } @@ -1087,7 +1092,7 @@ cap program drop outputtex program define outputtex syntax varlist, ddtab_resultMap(name) savetex(string) note(string) /// - [replace onerow starlevels(string) format(string) rwlbls(string) errortype(string) /// + [replace onerow format(string) rwlbls(string) errortype(string) /// texdocument texcaption(string) texlabel(string) texnotewidth(numlist) texvspace(string) cluster] * Replace tex file? From f5a9b8585d51256aea19cc4213ff0a0a1500c5d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Thu, 8 Nov 2018 17:58:12 -0500 Subject: [PATCH 12/21] ieddtab - update helpfile fix #165 --- src/help_files/ieddtab.sthlp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/help_files/ieddtab.sthlp b/src/help_files/ieddtab.sthlp index 1ee1cb1a..ee16eab0 100644 --- a/src/help_files/ieddtab.sthlp +++ b/src/help_files/ieddtab.sthlp @@ -17,6 +17,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {cmdab:t:ime(}{it:varname}{cmd:)} {cmdab:treat:ment(}{it:varname}{cmd:)} [ {cmdab:covar:iates(}{it:varlist}{cmd:)} {cmdab:starl:evels(}{it:numlist}{cmd:)} + {cmdab:stardrop} {cmdab:err:ortype(}{it:string}{cmd:)} {cmdab:rowl:abtype(}{it:string}{cmd:)} {cmdab:rowlabtext(}{it:label_string}{cmd:)} {cmdab:format(}{it:{help format:%fmt}}{cmd:)} {cmdab:replace} {cmdab:savet:ex(}{it:filepath}{cmd:)} {cmdab:onerow} @@ -39,6 +40,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {synopt :{cmdab:covar:iates(}{it:varlist}{cmd:)}}Covariates to use in diff-in-diff regression{p_end} {synopt :{cmdab:vce:(}{it:{help vce_option:vce_types}}{cmd:)}}Options for variance estimation. {hi:Robust}, {hi:cluster} {it:clustervar} or {hi:bootstrap}{p_end} {synopt :{cmdab:starl:evels(}{it:numlist}{cmd:)}}Significance levels used for significance stars, default values are .1, .05 and .01{p_end} +{synopt :{cmdab:stardrop}}Suppresses all significance stars in all tables.{p_end} {synopt :{cmdab:err:ortype(}{it:string}{cmd:)}}Type of errors to display, default is standard errors.{p_end} {pstd}{it:Output options:}{p_end} @@ -97,7 +99,9 @@ command. See {help vce_option:vce_types} for more details. The only vce types al Option {hi:robust} only applied to first and second difference estimators, not to baseline means.{p_end} -{phang}{cmdab:starl:evels(}{it:numlist}{cmd:)} sets the significance levels used for significance stars. Exactly three values must be listed if this option is used, all three values must be descending order, and must be between 0 and 1. The default values are .1, .05 and .01{p_end} +{phang}{cmdab:starl:evels(}{it:numlist}{cmd:)} sets the significance levels used for significance stars. Exactly three values must be listed if this option is used, all three values must be descending order, and must be between 0 and 1. The default values are .1, .05 and .01. The levels specified in this option is ignored if {cmdab:stardrop} is used.{p_end} + +{phang}{cmdab:stardrop}} suppresses all significance stars in all tables and remove the note on significance levels from the table note.{p_end} {phang}{cmdab:err:ortype(}{it:string}{cmd:)} sets the type of error to display. Allowed values for this iption is {inp:se} for standard errors, {inp:sd} for standard deviation and {inp:errhide} for not displaying any errors in the table. The default is to display standard errors.{p_end} From c7b311ef078f5485e9477673eaf8352cd56d8925 Mon Sep 17 00:00:00 2001 From: Benjamin Daniels Date: Fri, 9 Nov 2018 10:51:42 -0500 Subject: [PATCH 13/21] Add [weight] option to ieddtab --- src/ado_files/ieddtab.ado | 8 ++++---- src/help_files/ieddtab.sthlp | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index 10bbfb71..9add7e8b 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -3,7 +3,7 @@ cap program drop ieddtab program define ieddtab, rclass - syntax varlist(numeric) [if] [in], /// + syntax varlist(numeric) [if] [in] [aw fw iw pw], /// /// Time(varname numeric) TREATment(varname numeric) /// [ /// @@ -250,7 +250,7 @@ cap program drop ieddtab gen `interactionvar' = `treatment' * `time' *Run the regression to get the double difference - qui reg `var' `treatment' `time' `interactionvar' `covariates', `error_estm' + qui reg `var' `treatment' `time' `interactionvar' `covariates' [`weight'`exp'], `error_estm' mat resTable = r(table) **This is why this is done first. All other calculations @@ -297,7 +297,7 @@ cap program drop ieddtab forvalues tmt01 = 0/1 { *Regress time against the outcome var one tmt group at the time - qui reg `var' `time' `covariates' if `treatment' == `tmt01' & `regsample' == 1, `error_estm' + qui reg `var' `time' `covariates' if `treatment' == `tmt01' & `regsample' == 1 [`weight'`exp'], `error_estm' mat resTable = r(table) //Get the 1st diff @@ -338,7 +338,7 @@ cap program drop ieddtab forvalues t01 = 0/1 { *Summary stats on this group - qui mean `var' if `treatment' == `t01' & `time' == `tmt01' & `regsample' == 1, `error_estm_mean' + qui mean `var' if `treatment' == `t01' & `time' == `tmt01' & `regsample' == 1 [`weight'`exp'], `error_estm_mean' mat resTable = r(table) diff --git a/src/help_files/ieddtab.sthlp b/src/help_files/ieddtab.sthlp index 1ee1cb1a..79985a49 100644 --- a/src/help_files/ieddtab.sthlp +++ b/src/help_files/ieddtab.sthlp @@ -13,9 +13,9 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {title:Syntax} -{phang2} {cmdab:ieddtab} {it:varlist}, +{phang2} {cmdab:ieddtab} {it:varlist} [{help if}] [{help in}] [{help weight}], {cmdab:t:ime(}{it:varname}{cmd:)} {cmdab:treat:ment(}{it:varname}{cmd:)} - [ + {break}[ {cmdab:covar:iates(}{it:varlist}{cmd:)} {cmdab:starl:evels(}{it:numlist}{cmd:)} {cmdab:err:ortype(}{it:string}{cmd:)} {cmdab:rowl:abtype(}{it:string}{cmd:)} {cmdab:rowlabtext(}{it:label_string}{cmd:)} {cmdab:format(}{it:{help format:%fmt}}{cmd:)} From b205325ec925a6ab32b0a659f68820eb6371b175 Mon Sep 17 00:00:00 2001 From: Luiza Date: Fri, 9 Nov 2018 13:02:11 -0500 Subject: [PATCH 14/21] #175 : added weight option to the note --- src/ado_files/ieddtab.ado | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index 9add7e8b..60c52ee7 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -433,7 +433,21 @@ cap program drop ieddtab if "`vce_type'" == "bootstrap" local note_error "All columns display `variance_type_name' estimated using bootstrap. " } - local note `"`note_obs' `note_stars' `note_cov' `note_error'"' + * Add note on weights + if "`weight'" != "" { + local weightvar = subinstr("`exp'", "=", "", .) + local weightvar = stritrim(strtrim(`"`weightvar'"')) + + noi di "`weight'" + if "`weight'" == "aweight" local weightopt analytical + else if "`weight'" == "fweight" local weightopt frequency + else if "`weight'" == "pweight" local weightopt probability + else if "`weight'" == "iweight" local weightopt importance + + local note_weight "Variable `weightvar' used as `weightopt' weight. " + } + + local note `"`note_obs' `note_stars' `note_cov' `note_error' `note_weight'"' } From 181a1ca9fa711fc4eea167530373add2254c0cf8 Mon Sep 17 00:00:00 2001 From: Luiza Date: Fri, 9 Nov 2018 13:44:35 -0500 Subject: [PATCH 15/21] #161 : Added option nonumbers, not tested yet --- src/ado_files/ieddtab.ado | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index 60c52ee7..6f312d66 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -29,6 +29,7 @@ cap program drop ieddtab TEXLabel(string) /// TEXNotewidth(numlist min=1 max=1) /// texvspace(string) /// + nonumbers /// ] *Set minimum version for this command @@ -481,7 +482,7 @@ cap program drop ieddtab savetex(`savetex') `replace' /// `texdocument' texcaption("`texcaption'") texlabel("`texlabel'") texnotewidth(`texnotewidth') /// `onerow' starlevels("`starlevels'") format(`format') rwlbls("`rowlabels'") errortype(`errortype') /// - note(`note') texvspace("`texvspace'") `cluster' + note(`note') texvspace("`texvspace'") `cluster' `numbers' } @@ -1102,7 +1103,7 @@ cap program drop outputtex syntax varlist, ddtab_resultMap(name) savetex(string) note(string) /// [replace onerow starlevels(string) format(string) rwlbls(string) errortype(string) /// - texdocument texcaption(string) texlabel(string) texnotewidth(numlist) texvspace(string) cluster] + texdocument texcaption(string) texlabel(string) texnotewidth(numlist) texvspace(string) cluster nonumbers] * Replace tex file? if "`replace'" != "" local texreplace replace @@ -1124,7 +1125,7 @@ cap program drop outputtex texpreamble , texname("`texname'") texfile("`texfile'") texcaption("`texcaption'") texlabel("`texlabel'") `texdocument' * Write table header - texheader , texname("`texname'") texfile("`texfile'") `onerow' errortype(`errortype') `cluster' + texheader , texname("`texname'") texfile("`texfile'") `onerow' errortype(`errortype') `cluster' `nonumbers' * Write results texresults `varlist', ddtab_resultMap(ddtab_resultMap) /// @@ -1420,7 +1421,7 @@ end cap program drop texheader program define texheader - syntax , texname(string) texfile(string) errortype(string) [onerow cluster] + syntax , texname(string) texfile(string) errortype(string) [onerow cluster nonumbers] ** Calculate number of rows @@ -1442,6 +1443,16 @@ cap program drop texheader local ncol "`ncol'/{[}Clusters]" } } + + local colnorow = "" + + if "`numbers'" != "nonumbers" { + local colnomax = strlen("`colstring'") - 1 + forvalues colno = 1/`colnomax' { + local colnorow = `"`colnorow' & (`colno')"' + } + local colnorow = `"`colnorow' \\"' + } if "`errortype'" == "errhide" { if "`onerow'" != "" { @@ -1465,7 +1476,8 @@ cap program drop texheader "\hline \hline \\[-1.8ex]" _n /// "& \multicolumn{`toprowcols'}{c}{Control} & \multicolumn{`toprowcols'}{c}{Treatment} & \multicolumn{`bottomrowcols'}{c}{Difference-in-differences} \\" _n /// "& \multicolumn{`bottomrowcols'}{c}{Baseline} & \multicolumn{`bottomrowcols'}{c}{Difference} & \multicolumn{`bottomrowcols'}{c}{Baseline} & \multicolumn{`bottomrowcols'}{c}{Difference} & \multicolumn{`bottomrowcols'}{c}{} \\" _n /// - "Variable `ncol' & Mean`errortitle' `ncol' & Coef`errortitle' `ncol' & Mean`errortitle' `ncol' & Coef`errortitle' `ncol' & Coef`errortitle' \\ \hline" _n + "Variable `ncol' & Mean`errortitle' `ncol' & Coef`errortitle' `ncol' & Mean`errortitle' `ncol' & Coef`errortitle' `ncol' & Coef`errortitle' \\" _n /// + "`colnorow' \hline" _n file close `texname' end From 3d7d9771fe7dade5ad4354abe24f169db3410e80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Fri, 9 Nov 2018 14:15:34 -0500 Subject: [PATCH 16/21] update to version 6.1 #174 --- src/ado_files/iebaltab.ado | 2 +- src/ado_files/ieboilsave.ado | 2 +- src/ado_files/ieboilstart.ado | 2 +- src/ado_files/iecompdup.ado | 2 +- src/ado_files/ieddtab.ado | 8 ++++---- src/ado_files/iedropone.ado | 2 +- src/ado_files/ieduplicates.ado | 4 ++-- src/ado_files/iefolder.ado | 2 +- src/ado_files/iegitaddmd.ado | 2 +- src/ado_files/iegraph.ado | 4 ++-- src/ado_files/iematch.ado | 2 +- src/ado_files/ietoolkit.ado | 2 +- src/help_files/iebaltab.sthlp | 2 +- src/help_files/ieboilsave.sthlp | 2 +- src/help_files/ieboilstart.sthlp | 2 +- src/help_files/iecompdup.sthlp | 2 +- src/help_files/ieddtab.sthlp | 2 +- src/help_files/iedropone.sthlp | 2 +- src/help_files/ieduplicates.sthlp | 2 +- src/help_files/iefolder.sthlp | 2 +- src/help_files/iegitaddmd.sthlp | 2 +- src/help_files/iegraph.sthlp | 2 +- src/help_files/iematch.sthlp | 2 +- src/help_files/ietoolkit.sthlp | 2 +- 24 files changed, 29 insertions(+), 29 deletions(-) diff --git a/src/ado_files/iebaltab.ado b/src/ado_files/iebaltab.ado index d6506c05..1159ee31 100644 --- a/src/ado_files/iebaltab.ado +++ b/src/ado_files/iebaltab.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop iebaltab program iebaltab diff --git a/src/ado_files/ieboilsave.ado b/src/ado_files/ieboilsave.ado index c8e8e74f..c1b6c69a 100644 --- a/src/ado_files/ieboilsave.ado +++ b/src/ado_files/ieboilsave.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop ieboilsave program ieboilsave , rclass diff --git a/src/ado_files/ieboilstart.ado b/src/ado_files/ieboilstart.ado index 2be2325d..623761f2 100644 --- a/src/ado_files/ieboilstart.ado +++ b/src/ado_files/ieboilstart.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop ieboilstart program ieboilstart , rclass diff --git a/src/ado_files/iecompdup.ado b/src/ado_files/iecompdup.ado index 2149dd67..2cf68118 100644 --- a/src/ado_files/iecompdup.ado +++ b/src/ado_files/iecompdup.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop iecompdup program iecompdup , rclass diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index 4ad29985..5dc2a22e 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org cap program drop ieddtab program define ieddtab, rclass @@ -440,16 +440,16 @@ cap program drop ieddtab if "`weight'" != "" { local weightvar = subinstr("`exp'", "=", "", .) local weightvar = stritrim(strtrim(`"`weightvar'"')) - + noi di "`weight'" if "`weight'" == "aweight" local weightopt analytical else if "`weight'" == "fweight" local weightopt frequency else if "`weight'" == "pweight" local weightopt probability else if "`weight'" == "iweight" local weightopt importance - + local note_weight "Variable `weightvar' used as `weightopt' weight. " } - + local note `"`note_obs' `note_stars' `note_cov' `note_error' `note_weight'"' } diff --git a/src/ado_files/iedropone.ado b/src/ado_files/iedropone.ado index 730af9f0..a400809e 100644 --- a/src/ado_files/iedropone.ado +++ b/src/ado_files/iedropone.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop iedropone program define iedropone , diff --git a/src/ado_files/ieduplicates.ado b/src/ado_files/ieduplicates.ado index 25f2f94c..1087c5cf 100644 --- a/src/ado_files/ieduplicates.ado +++ b/src/ado_files/ieduplicates.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop ieduplicates program ieduplicates , rclass @@ -333,7 +333,7 @@ } *Same error for any incorrect input - + di as error "{phang}Since there was at least one error in the Excel report no corrections have been made to the duplicates in the data set. Please address the errors above and then run the command again.{p_end}" error 198 exit diff --git a/src/ado_files/iefolder.ado b/src/ado_files/iefolder.ado index 78a74540..b03d0371 100644 --- a/src/ado_files/iefolder.ado +++ b/src/ado_files/iefolder.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org cap program drop iefolder program define iefolder diff --git a/src/ado_files/iegitaddmd.ado b/src/ado_files/iegitaddmd.ado index 1a54d280..a8a66dc3 100644 --- a/src/ado_files/iegitaddmd.ado +++ b/src/ado_files/iegitaddmd.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org cap program drop iegitaddmd program define iegitaddmd diff --git a/src/ado_files/iegraph.ado b/src/ado_files/iegraph.ado index dde9179c..5258d180 100644 --- a/src/ado_files/iegraph.ado +++ b/src/ado_files/iegraph.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org cap program drop iegraph program define iegraph, rclass @@ -21,7 +21,7 @@ cap program drop iegraph ignoredummytest /// norestore /// save(string) *] - + if "`restore'" == "" preserve qui { diff --git a/src/ado_files/iematch.ado b/src/ado_files/iematch.ado index 3b250c98..65e0a72f 100644 --- a/src/ado_files/iematch.ado +++ b/src/ado_files/iematch.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org cap program drop iematch program define iematch diff --git a/src/ado_files/ietoolkit.ado b/src/ado_files/ietoolkit.ado index a6985912..bb25168f 100644 --- a/src/ado_files/ietoolkit.ado +++ b/src/ado_files/ietoolkit.ado @@ -1,4 +1,4 @@ -*! version 6.0 19OCT2018 DIME Analytics dimeanalytics@worldbank.org +*! version 6.1 09112018 DIME Analytics dimeanalytics@worldbank.org capture program drop ietoolkit program ietoolkit, rclass diff --git a/src/help_files/iebaltab.sthlp b/src/help_files/iebaltab.sthlp index e0438756..3dc9159b 100644 --- a/src/help_files/iebaltab.sthlp +++ b/src/help_files/iebaltab.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iebaltab} {hline} diff --git a/src/help_files/ieboilsave.sthlp b/src/help_files/ieboilsave.sthlp index a630c0bd..74789d98 100644 --- a/src/help_files/ieboilsave.sthlp +++ b/src/help_files/ieboilsave.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:ieboilsave} {hline} diff --git a/src/help_files/ieboilstart.sthlp b/src/help_files/ieboilstart.sthlp index 007e6ba2..ad8f53c0 100644 --- a/src/help_files/ieboilstart.sthlp +++ b/src/help_files/ieboilstart.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:ieboilstart} {hline} diff --git a/src/help_files/iecompdup.sthlp b/src/help_files/iecompdup.sthlp index d3e8ad28..4d213d5b 100644 --- a/src/help_files/iecompdup.sthlp +++ b/src/help_files/iecompdup.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iecompdup} {hline} diff --git a/src/help_files/ieddtab.sthlp b/src/help_files/ieddtab.sthlp index 04475040..09352dfa 100644 --- a/src/help_files/ieddtab.sthlp +++ b/src/help_files/ieddtab.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:ieddtab} {hline} diff --git a/src/help_files/iedropone.sthlp b/src/help_files/iedropone.sthlp index 771debaf..319dc6de 100644 --- a/src/help_files/iedropone.sthlp +++ b/src/help_files/iedropone.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iedropone} {hline} diff --git a/src/help_files/ieduplicates.sthlp b/src/help_files/ieduplicates.sthlp index 50d168c1..a0494ac9 100644 --- a/src/help_files/ieduplicates.sthlp +++ b/src/help_files/ieduplicates.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:ieduplicates} {hline} diff --git a/src/help_files/iefolder.sthlp b/src/help_files/iefolder.sthlp index 46ca27de..800ad0e4 100644 --- a/src/help_files/iefolder.sthlp +++ b/src/help_files/iefolder.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iefolder} {hline} diff --git a/src/help_files/iegitaddmd.sthlp b/src/help_files/iegitaddmd.sthlp index e04cfc0d..8474b455 100644 --- a/src/help_files/iegitaddmd.sthlp +++ b/src/help_files/iegitaddmd.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iegitaddmd} {hline} diff --git a/src/help_files/iegraph.sthlp b/src/help_files/iegraph.sthlp index 52bd9d7b..bcdecc92 100644 --- a/src/help_files/iegraph.sthlp +++ b/src/help_files/iegraph.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iegraph} {hline} diff --git a/src/help_files/iematch.sthlp b/src/help_files/iematch.sthlp index 67f90ecc..17679a5c 100644 --- a/src/help_files/iematch.sthlp +++ b/src/help_files/iematch.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:iematch} {hline} diff --git a/src/help_files/ietoolkit.sthlp b/src/help_files/ietoolkit.sthlp index 2e61c2c5..d7c583a4 100644 --- a/src/help_files/ietoolkit.sthlp +++ b/src/help_files/ietoolkit.sthlp @@ -1,5 +1,5 @@ {smcl} -{* 19 Oct 2018}{...} +{* 09 Nov 2018}{...} {hline} help for {hi:ietoolkit} {hline} From d1079241703d486d0743da3cb6e284dfb67fabec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Fri, 9 Nov 2018 14:17:10 -0500 Subject: [PATCH 17/21] ietoolkit : update version locals --- src/ado_files/ietoolkit.ado | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ado_files/ietoolkit.ado b/src/ado_files/ietoolkit.ado index bb25168f..9f215298 100644 --- a/src/ado_files/ietoolkit.ado +++ b/src/ado_files/ietoolkit.ado @@ -4,8 +4,8 @@ capture program drop ietoolkit program ietoolkit, rclass * UPDATE THESE LOCALS FOR EACH NEW VERSION PUBLISHED - local version "6.0" - local versionDate "19OCT2018" + local version "6.1" + local versionDate "11NOV2018" syntax [anything] From b63987086cc3b8ab0b36066723e0a36f18a79d41 Mon Sep 17 00:00:00 2001 From: Luiza Date: Fri, 9 Nov 2018 17:10:57 -0500 Subject: [PATCH 18/21] #161: now working --- src/ado_files/ieddtab.ado | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index 6f312d66..60d01794 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -1125,7 +1125,7 @@ cap program drop outputtex texpreamble , texname("`texname'") texfile("`texfile'") texcaption("`texcaption'") texlabel("`texlabel'") `texdocument' * Write table header - texheader , texname("`texname'") texfile("`texfile'") `onerow' errortype(`errortype') `cluster' `nonumbers' + texheader , texname("`texname'") texfile("`texfile'") `onerow' errortype(`errortype') `cluster' `numbers' * Write results texresults `varlist', ddtab_resultMap(ddtab_resultMap) /// From 4dc6ab4258239e9be86323a6907486ddb25c576c Mon Sep 17 00:00:00 2001 From: Luiza Date: Fri, 9 Nov 2018 17:16:32 -0500 Subject: [PATCH 19/21] #161: added nonumbers option to helpfile --- src/help_files/ieddtab.sthlp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/help_files/ieddtab.sthlp b/src/help_files/ieddtab.sthlp index 79985a49..2104e887 100644 --- a/src/help_files/ieddtab.sthlp +++ b/src/help_files/ieddtab.sthlp @@ -19,7 +19,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {cmdab:covar:iates(}{it:varlist}{cmd:)} {cmdab:starl:evels(}{it:numlist}{cmd:)} {cmdab:err:ortype(}{it:string}{cmd:)} {cmdab:rowl:abtype(}{it:string}{cmd:)} {cmdab:rowlabtext(}{it:label_string}{cmd:)} {cmdab:format(}{it:{help format:%fmt}}{cmd:)} - {cmdab:replace} {cmdab:savet:ex(}{it:filepath}{cmd:)} {cmdab:onerow} + {cmdab:replace} {cmdab:savet:ex(}{it:filepath}{cmd:)} {cmdab:onerow} {cmdab:nonumbers} {cmdab:nonotes} {cmdab:addn:otes(}{it:string}{cmd:)} {cmdab:texdoc:ument} {cmdab:texc:aption(}{it:string}{cmd:)} {cmdab:texl:abel(}{it:string}{cmd:)} {cmdab:texn:otewidth(}{it:numlist}{cmd:)} {cmdab:texvspace(}{it:string}{cmd:)} @@ -57,6 +57,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {synopt :{cmdab:texl:abel(}{it:string}{cmd:)}}Specify table's label, used for meta-reference across TeX file.{p_end} {synopt :{cmdab:texn:otewidth(}{it:numlist}{cmd:)}}Manually enter the width of the note on the TeX file.{p_end} {synopt :{cmd:texvspace(}{it:string}{cmd:)}}Manually set size of the line space between two rows on TeX output.{p_end} +{synopt :{cmdab:nonumbers}}Ommit column numbers from table header in LaTeX output.{p_end} {synoptline} {marker desc} @@ -110,7 +111,7 @@ Option {hi:robust} only applied to first and second difference estimators, not t {phang}{cmdab:addn:otes(}{it:string}{cmd:)} is used to manually add a note to be displayed below the regression result table. This note is put before the automatically generated note, unless option {cmdab:nonotes} is specified, in which case only the manually added note is displayed.{p_end} -{phang}{cmdab:onerow} indicated that the number of observations should be displayed on one row at the last row of the table instead on each row. This requires that the number of observations are the same across all rows for each column.{p_end} +{phang}{cmdab:onerow} indicates that the number of observations should be displayed on one row at the last row of the table instead on each row. This requires that the number of observations are the same across all rows for each column.{p_end} {phang}{cmdab:format(}{it:{help format:%fmt}}{cmd:)} sets the number formatting/rounding rule for all calculated statistics in the table, that is all numbers in the table apart from the number of observations. Only valid {help format:Stata number formats} are allowed. The default is {it:%9.2f}.{p_end} @@ -134,6 +135,8 @@ and one of the following units: "cm", "mm", "pt", "in", "ex" or "em". Note that specified value minus the height of one line of text. Default is "3ex". For more information on units, {browse "https://en.wikibooks.org/wiki/LaTeX/Lengths":check LaTeX lengths manual}. {p_end} +{phang}{cmdab:nonumbers} ommits column numbers from table header in LaTeX output. Default is to display column numbers.{p_end} + {marker optslong} {title:Examples} From a7e1b064daece04ca66ce1a499a48166f4a5da8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Fri, 9 Nov 2018 18:04:23 -0500 Subject: [PATCH 20/21] ieddtab - small typo in helpfile --- src/help_files/ieddtab.sthlp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/help_files/ieddtab.sthlp b/src/help_files/ieddtab.sthlp index 0111f855..521da7aa 100644 --- a/src/help_files/ieddtab.sthlp +++ b/src/help_files/ieddtab.sthlp @@ -59,7 +59,7 @@ command please see the {browse "https://dimewiki.worldbank.org/wiki/ieddtab":DIM {synopt :{cmdab:texl:abel(}{it:string}{cmd:)}}Specify table's label, used for meta-reference across TeX file.{p_end} {synopt :{cmdab:texn:otewidth(}{it:numlist}{cmd:)}}Manually enter the width of the note on the TeX file.{p_end} {synopt :{cmd:texvspace(}{it:string}{cmd:)}}Manually set size of the line space between two rows on TeX output.{p_end} -{synopt :{cmdab:nonumbers}}Ommit column numbers from table header in LaTeX output.{p_end} +{synopt :{cmdab:nonumbers}}Omit column numbers from table header in LaTeX output.{p_end} {synoptline} {marker desc} From 105c950921071675f560d88ec897045059a2e8d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristoffer=20Bj=C3=A4rkefur?= Date: Fri, 9 Nov 2018 18:12:15 -0500 Subject: [PATCH 21/21] ieddtab : add some comments --- src/ado_files/ieddtab.ado | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ado_files/ieddtab.ado b/src/ado_files/ieddtab.ado index f192e52a..c6f1d276 100644 --- a/src/ado_files/ieddtab.ado +++ b/src/ado_files/ieddtab.ado @@ -1448,9 +1448,9 @@ cap program drop texheader local ncol "`ncol'/{[}Clusters]" } } - + + *Unless option nonumbers is used, number all columns in tex output local colnorow = "" - if "`numbers'" != "nonumbers" { local colnomax = strlen("`colstring'") - 1 forvalues colno = 1/`colnomax' { @@ -1459,6 +1459,7 @@ cap program drop texheader local colnorow = `"`colnorow' \\"' } + *Write part of header that explains which type of errors are displayed if "`errortype'" == "errhide" { if "`onerow'" != "" { local errortitle ""