Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt before tagging Gutenberg #230

Open
jhnstn opened this issue Dec 4, 2023 · 0 comments
Open

Add prompt before tagging Gutenberg #230

jhnstn opened this issue Dec 4, 2023 · 0 comments

Comments

@jhnstn
Copy link
Member

jhnstn commented Dec 4, 2023

While in most cases tagging after creating the PR should be safe there are cases where a minor change needs to be added after the release script has ran. This is usually just a change note update.

We should add a prompt before tagging to

  1. Allow the wrangler to review the PR on Github before the tag is created
  2. Allow the wrangler to skip the tagging

In the later case we might want to print out the git tag command since our manual instructions have resulted in a mix of lightweight and annotated tags on Gutenberg. This should be output at the very end of the command run especially during a prepare all run since the tagging step is in the middle of the run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant