Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Block: "Play inline" setting doesn't get saved #1721

Closed
designsimply opened this issue Dec 23, 2019 · 4 comments
Closed

Video Block: "Play inline" setting doesn't get saved #1721

designsimply opened this issue Dec 23, 2019 · 4 comments
Assignees
Labels

Comments

@designsimply
Copy link
Contributor

Steps to reproduce:

  1. Add a video block or open a post that already has one.
  2. Tap the gear icon.
  3. Toggle the "Play inline" setting to on.
  4. Save the post and re-open it.
  5. Check to see if the "Play inline" setting is still on.

Result: the "Play inline" setting is off after turning it on and saving then re-opening the post. (24s iOS, 37s Android)

play-inline-setting-not-saved-wpios-13 9-beta play-inline-setting-not-saved-wpandroid-13 9-beta
Tested with WPiOS 13.9.0.0 TestFlight beta on iPhone 6S iOS 13.2.3 and WPAndroid 13.9-rc-1 on Pixel 3 Android 10.

@designsimply designsimply added [Type] Bug Something isn't working Beta Request labels Dec 23, 2019
@SergioEstevao
Copy link
Contributor

I did some more testing, and it looks that locally the code is working correctly, the setting is saved and you can check that by switching to HTML mode and back.

When the post is saved to the server the it’s look the playsinline attribute is stripped from the video element inside the block. So the post content returned from the server no longer has the playsinline attributed and the setting is lost.

This only happens on WP.com sites or sites that have Jetpack active and the VideoPress option ON, on .org site the setting is kept.

I will try to investigate on the WP.com server code to see the reason for this to happen.

@SergioEstevao SergioEstevao self-assigned this Jan 5, 2020
@hypest
Copy link
Contributor

hypest commented Jan 27, 2020

This only happens on WP.com sites or sites that have Jetpack active and the VideoPress option ON, on .org site the setting is kept.

Interesting, does the issue also happens on Gutenberg on the web against .com sites?

@guarani
Copy link
Contributor

guarani commented Apr 7, 2020

Interesting, does the issue also happens on Gutenberg on the web against .com sites?

The "Plays Inline" option is missing from the video block settings panel on WordPress.com, when adding a video hosted on VideoPress or uploading a video. It's present if linking to a video hosted externally.

.com .org
Screen Shot 2020-04-06 at 23 10 06 Screen Shot 2020-04-06 at 23 03 43

If you add the attribute using the code editor on WordPress.com, it is also stripped.

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 23, 2024

Fixed in Automattic/jetpack#35637.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants