Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing social sharing icons #23918

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 20, 2024

Fixes #23860.

My initial idea was to finally remove all the local icons and fetch them remotely, but it's not currently possible because half of these remote icons are outdated and some of the (Threads) have no background and don't work in dark mode. So the app has to have local overrides.

Changes:

  • Update JetpackSocialNoConnectionView.swift to cache remote icons using CachedImageView
  • Add new override for Threads (fixes dark mode)
  • Add support for fetching remote images in SharingViewController.m (site Sharing Settings).

Unfortunately, there is still one more place that needs to be updated and it's not perfect, but I ran out of time, so maybe next time. It fixed the most obvious issues.

Before

Screenshot 2024-12-20 at 3 27 29 PM Screenshot 2024-12-20 at 3 27 31 PM

Screenshot 2024-12-20 at 3 30 01 PM Screenshot 2024-12-20 at 3 30 02 PM

After

Screenshot 2024-12-20 at 3 50 17 PM Screenshot 2024-12-20 at 3 50 16 PM

Screenshot 2024-12-20 at 3 42 04 PM Screenshot 2024-12-20 at 3 42 02 PM

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Sharing label Dec 20, 2024
@kean kean added this to the 25.6 ❄️ milestone Dec 20, 2024
@kean kean requested a review from crazytonyli December 20, 2024 20:58
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 20, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23918-32aaa98
Version25.6
Bundle IDorg.wordpress.alpha
Commit32aaa98
App Center BuildWPiOS - One-Offs #11219
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23918-32aaa98
Version25.6
Bundle IDcom.jetpack.alpha
Commit32aaa98
App Center Buildjetpack-installable-builds #10257
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing social icons
3 participants