-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Fix ReaderPostTable sorting date as string #19949
Merged
RenanLukas
merged 9 commits into
feature/reader-ia
from
issue/19897-fix-readerposttable-sorting-date-as-string
Jan 16, 2024
Merged
[Reader IA] Fix ReaderPostTable sorting date as string #19949
RenanLukas
merged 9 commits into
feature/reader-ia
from
issue/19897-fix-readerposttable-sorting-date-as-string
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These entities were being sorted by date_liked as a string, and it was working because they are being inserted with the same timezone. This solution is weak, because if the timezone ever changes among entities the sorting will stop working. Using datetime function solves this issue.
These entities were being sorted by date_published as a string, and it works as long as they are inserted with the same timezone. This solution is weak, because if the timezone ever changes among entities the sorting will stop working. Using datetime function solves this issue.
These entities were being sorted by date_tagged as a string, and it works as long as they are inserted with the same timezone. This solution is weak, because if the timezone ever changes among entities the sorting will stop working. Using datetime function solves this issue.
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
…-sorting-date-as-string
Generated by 🚫 dangerJS |
Generated by 🚫 Danger |
thomashorta
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and changes seem to be working as expected. Thanks for this PR!
RenanLukas
deleted the
issue/19897-fix-readerposttable-sorting-date-as-string
branch
January 16, 2024 22:09
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19897
I've changed the methods that were previously sorting dates as strings to use
datetime
inReaderPostTable
(see issue for context). In all scenarios the sorting was already working as expected, but this is only true because the posts have the same timezone. It's a weak solution IMHO because if the timezone changes it will break the sorting everywhere. The goal of this PR is to avoid having these problems in the future (like we had with #19881).To Test:
Basically Reader feeds have to continue working as expected.
date_publishing
(see here);Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: