-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Block missing required metadata and using incorrect source in post_content after going Atomic when Gutenberg active #17751
Comments
According to the logs in 5832652-zd-woothemes, the user was using the app version 21.3 on Samsung SM-G986B. I performed a test with an Atomic site with Gutenberg activated, but I couldn't reproduce the issue. The video block stayed in the editor after I uploaded the video from the Android app and published it from there. Tested on app version 21.3, Android 13, Nexus 5X (Android Studio emulator). |
I was able to reproduce this on Android 10 with app version 21.4 on a test Atomic site. On a new video upload directly from the video block, it consistently sets post_content incorrectly like this with a bad source:
Interestingly, if you create another post and select the same uploaded video from the media library instead, it works fine and sets the post_content correctly like this:
A workaround is to upload the video to the media library first, create a new post, add a video block, and choose the video from the media library. Uploading directly from the video block by choosing from device or taking a video and posting creates broken video blocks. |
This was also reported in #6089928-zen:
I've also been able to consistently replicate the issue on my AT test sites with my SM-S918B/DS. The issue is still reproducible on version 22.2-rc-1 of the app. In my tests, simply editing the post in a browser, waiting for the video to load, and updating the post corrects the issue. This has also been discussed in p1681460173333039-slack-C0180B5PRJ4. |
I debugged this issue some today. I observed that media upload requests return a different
This notably different to the following returned for Simple sites when using the Android app or any site type when using the iOS app:
This difference aligns with the incorrect block meta data shared previously. It seems as though the unexpected URL originates in the new media API endpoint. |
Removing my assignment from this issue as I focus on other work. For anyone who continues work on this issue in the future, my recommendation for next steps would be exploring the logic of the endpoint used for uploading media. We could use a WPCOM sandbox environment to explore if/how the endpoint might be overridden/extended and why Atomic sites return a different value. |
I re-engaged debugging this for this past week.
For anyone who continues work on this issue, I recommend further researching:
Removing my assignment from this issue as I focus on other work. |
I believe this will be resolved when the changes in Automattic/jetpack#35637 are included in the upcoming 24.4 release. With that change, when VideoPress v5 is detected (the default for dotcom video uploads), the Let me know if anything further needs to be iterated on here, but I'll go ahead to close for now. |
Expected behavior
A user reported issues with videos in new posts not displaying after their site went Atomic. Initially, this seemed related to metadata missing on the videos when site went Atomic. The metadata was fixed and this issue is now only happening when posting from the Android app and only when Gutenberg is activated. With Gutenberg deactivated on mobile, the videos work fine and post content also looks fine.
User expects videos to load as they always have when posting from Android app prior to upgrading their plan to Business.
Actual behavior
When posting from the Android app with Gutenberg active, the user can see the video while previewing. Upon saving, the post content is created with a video block like below. This has missing metadata (it does exist) and uses an invalid source that causes a 404 that prevents the video from loading on the frontend:
When updating a different broken video post on Desktop, with Gutenberg active and without making any changes, the post content changes to something like this with additional metadata, and the video loads. Post content is similar when posting from the app with Gutenberg deactivated:
Prior to going Atomic, their post content on working videos looked like this:
Steps to reproduce the behavior
We have been trying to gather device/OS information and the Android app version. It is not entirely known as they are frustrated and just want things to work. They last reported they are using a Samsung S20+ with everything fully updated.
The text was updated successfully, but these errors were encountered: