Merge pull request #20346 from wordpress-mobile/origin/fix/20287-talk…

…back-stats-crash Fix crashes with Traffic tab when Talkback enabled
wordpress-mobile · Mar 1, 2024 · 7508d71 · 7508d71
2 parents b355f63 + 8cae948
commit 7508d71
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/...rg/wordpress/android/ui/stats/refresh/lists/sections/traffic/TrafficBarChartViewHolder.kt b/...rg/wordpress/android/ui/stats/refresh/lists/sections/traffic/TrafficBarChartViewHolder.kt
@@ -69,20 +69,23 @@ class TrafficBarChartViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
 
     private fun BarChart.draw(item: BlockListItem.TrafficBarChartItem): Int {
         resetChart()
+        val dataSet = getData(item)
+        val dataSets = mutableListOf<IBarDataSet>()
+        dataSets.add(dataSet)
 
-        data = BarData(getData(item))
+        data = BarData(dataSets)
 
         configureChartView()
         configureYAxis(item)
         configureXAxis(item)
 
         invalidate()
-        return data.dataSets.size
+        return dataSet.entryCount
     }
 
     private fun hasData(entries: List<Bar>) = entries.isNotEmpty() && entries.any { it.value > 0 }
 
-    private fun getData(item: BlockListItem.TrafficBarChartItem): List<IBarDataSet> {
+    private fun getData(item: BlockListItem.TrafficBarChartItem): IBarDataSet {
         val minColumnCount = 5
 
         val graphWidth = DisplayUtils.pxToDp(chart.context, chart.width)
@@ -97,10 +100,8 @@ class TrafficBarChartViewHolder(parent: ViewGroup) : BlockListItemViewHolder(
             buildEmptyDataSet(chart.context, cutEntries.size)
         }
         item.onBarChartDrawn?.invoke(dataSet.entryCount)
-        val dataSets = mutableListOf<IBarDataSet>()
-        dataSets.add(dataSet)
 
-        return dataSets
+        return dataSet
     }
 
     private fun configureChartView() {

diff --git a/...a/org/wordpress/android/ui/stats/refresh/lists/sections/traffic/TrafficOverviewUseCase.kt b/...a/org/wordpress/android/ui/stats/refresh/lists/sections/traffic/TrafficOverviewUseCase.kt
@@ -282,7 +282,7 @@ class TrafficOverviewUseCase(
             lowerGranularity
         )
         if (period != null && period != "empty") {
-            val selectedDate = statsDateFormatter.parseStatsDate(statsGranularity, period)
+            val selectedDate = statsDateFormatter.parseStatsDate(lowerGranularity, period)
             selectedDateProvider.selectDate(
                 selectedDate,
                 lowerGranularity