Apply PR suggestion: use material_emphasis_disabled instead of creati…

…ng new value
wordpress-mobile · Mar 11, 2024 · 2168f10 · 2168f10
1 parent a62d139
commit 2168f10
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/WordPress/src/main/res/color/on_surface_medium_secondary_selector.xml b/WordPress/src/main/res/color/on_surface_medium_secondary_selector.xml
@@ -2,8 +2,8 @@
 
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
 
-    <item android:alpha="@dimen/reader_comments_like_count_disabled_alpha" android:color="?attr/colorOnSurface" android:state_enabled="false" android:state_selected="false" />
-    <item android:alpha="@dimen/reader_comments_like_count_disabled_alpha" android:color="?attr/colorOnSurface" android:state_enabled="false" android:state_selected="true" />
+    <item android:alpha="@dimen/material_emphasis_disabled" android:color="?attr/colorOnSurface" android:state_enabled="false" android:state_selected="false" />
+    <item android:alpha="@dimen/material_emphasis_disabled" android:color="?attr/colorOnSurface" android:state_enabled="false" android:state_selected="true" />
     <item android:color="?attr/colorSecondary" android:state_enabled="true" android:state_selected="true" />
     <item android:alpha="@dimen/material_emphasis_medium" android:color="?attr/colorOnSurface" />
 

diff --git a/WordPress/src/main/res/values/dimens.xml b/WordPress/src/main/res/values/dimens.xml
@@ -227,7 +227,6 @@
     <dimen name="reader_comments_actions_height">24dp</dimen>
     <dimen name="reader_comments_content_line_height">24dp</dimen>
     <dimen name="reader_comments_selected_indicator_width">6dp</dimen>
-    <item name="reader_comments_like_count_disabled_alpha" format="float" type="dimen">0.35</item>
 
     <!-- Increased touch targets to make views more accessible -->
     <dimen name="reader_discover_layout_extra_padding">16dp</dimen>