Merge branch 'trunk' into fix/jp_powered_copy

.github/workflows/run-danger.yml

@@ -2,10 +2,12 @@ name: ☢️ Danger
 
 on:
   pull_request:
-    types: [opened, synchronize, edited, review_requested, review_request_removed, labeled, unlabeled, milestoned, demilestoned]
+    types: [opened, reopened, ready_for_review, synchronize, edited, labeled, unlabeled, milestoned, demilestoned]
 
 jobs:
   dangermattic:
-    uses: Automattic/dangermattic/.github/workflows/reusable-run-danger.yml@trunk
+    # runs on draft PRs only for opened / synchronize events
+    if: ${{ (github.event.pull_request.draft == false) || (github.event.pull_request.draft == true && contains(fromJSON('["opened", "synchronize"]'), github.event.action)) }}
+    uses: Automattic/dangermattic/.github/workflows/[email protected]
     secrets:
       github-token: ${{ secrets.DANGERMATTIC_GITHUB_TOKEN }}

.github/workflows/validate-issues.yml

@@ -0,0 +1,18 @@
+name: 📝 Validate Issues
+
+on:
+  issues:
+    types: [opened, labeled, unlabeled]
+
+jobs:
+  check-labels-on-issues:
+    uses: Automattic/dangermattic/.github/workflows/[email protected]
+    with:
+      label-format-list: '[
+        "^\[.+\]",
+        "^[[:alnum:]]"
+      ]'
+      label-error-message: '🚫 Please add a type label (e.g. **[Type] Enhancement**) and a feature label (e.g. **Stats**) to this issue.'
+      label-success-message: 'Thanks for reporting! 👍'
+    secrets:
+      github-token: ${{ secrets.DANGERMATTIC_GITHUB_TOKEN }}

Dangerfile

@@ -1,41 +1,46 @@
 # frozen_string_literal: true
 
-def release_branch?
-  danger.github.branch_for_base.start_with?('release/') || danger.github.branch_for_base.start_with?('hotfix/')
-end
+github.dismiss_out_of_range_messages
 
-def main_branch?
-  danger.github.branch_for_base == 'trunk'
-end
+# `files: []` forces rubocop to scan all files, not just the ones modified in the PR
+rubocop.lint(files: [], force_exclusion: true, inline_comment: true, fail_on_inline_comment: true, include_cop_names: true)
 
-def wip_feature?
-  has_wip_label = github.pr_labels.any? { |label| label.include?('WIP') }
-  has_wip_title = github.pr_title.include?('WIP')
+manifest_pr_checker.check_gemfile_lock_updated
 
-  has_wip_label || has_wip_title
-end
+android_release_checker.check_release_notes_and_play_store_strings
 
-return if github.pr_labels.include?('Releases')
+android_strings_checker.check_strings_do_not_refer_resource
 
-github.dismiss_out_of_range_messages
+# skip remaining checks if we're in a release-process PR
+if github.pr_labels.include?('Releases')
+  message('This PR has the `Releases` label: some checks will be skipped.')
+  return
+end
 
-manifest_pr_checker.check_gemfile_lock_updated
+common_release_checker.check_internal_release_notes_changed(report_type: :message)
 
-labels_checker.check(
-  required_labels: [//],
-  required_labels_error: 'PR requires at least one label.'
-)
+android_release_checker.check_modified_strings_on_release
 
-view_changes_need_screenshots.view_changes_need_screenshots
+view_changes_checker.check
 
 pr_size_checker.check_diff_size(
-  file_selector: ->(path) { !path.include?('/src/test') },
-  max_size: 300
+  max_size: 300,
+  file_selector: ->(path) { !path.include?('/src/test') }
 )
 
 android_unit_test_checker.check_missing_tests
 
-# skip check for draft PRs and for WIP features unless the PR is against the main branch or release branch
-milestone_checker.check_milestone_due_date(days_before_due: 4) unless github.pr_draft? || (wip_feature? && !(release_branch? || main_branch?))
+# skip remaining checks if the PR is still a Draft
+if github.pr_draft?
+  message('This PR is still a Draft: some checks will be skipped.')
+  return
+end
+
+labels_checker.check(
+  do_not_merge_labels: ['Do Not Merge'],
+  required_labels: [//],
+  required_labels_error: 'PR requires at least one label.'
+)
 
-rubocop.lint(inline_comment: true, fail_on_inline_comment: true, include_cop_names: true)
+# runs the milestone check if this is not a WIP feature and the PR is against the main branch or the release branch
+milestone_checker.check_milestone_due_date(days_before_due: 4) if (github_utils.main_branch? || github_utils.release_branch?) && !github_utils.wip_feature?

Gemfile

@@ -2,7 +2,7 @@
 
 source 'https://rubygems.org'
 
-gem 'danger-dangermattic', git: 'https://github.com/Automattic/dangermattic'
+gem 'danger-dangermattic', '~> 1.0'
 gem 'fastlane', '~> 2'
 gem 'nokogiri'