Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining binary calls in MoneroDaemonRpc.java #16

Open
woodser opened this issue Aug 16, 2019 · 0 comments
Open

Implement remaining binary calls in MoneroDaemonRpc.java #16

woodser opened this issue Aug 16, 2019 · 0 comments

Comments

@woodser
Copy link
Owner

woodser commented Aug 16, 2019

The Java client to daemon RPC already supports a number of binary calls. For example, getBlocksByHeight() uses the binary RPC call get_blocks_by_height.bin.

This issue requests support for the remaining binary calls in MoneroDaemonRpc.java. Their implementation should follow the patterns of the already implemented binary calls, but may require additional processing like de-serializing some of the response fields which are also binary.

Last checked, these were the remaining binary calls to be implemented in MoneroDaemonRpc.java. This list was generated from the failures of running TestMoneroDaemonRpc.java as a JUnit test and from the unimplemented methods in MoneroDaemonRpc.java.

  • getBlocksById()
  • getBlockIds() (get_hashes.bin)
  • getTxPoolIds() (get_transaction_pool_hashes.bin)
  • getTxPoolBacklog() (get_txpool_backlog)
  • getOutputs()
  • getOutputDistribution() (response distribution field is binary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant