Support for hybrid authentication (two ciphers) #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
force-pushed
the
hybrid-auth
branch
from
2168518
to
2b7b5d8
Compare
danielinux
force-pushed
the
hybrid-auth
branch
5 times, most recently
from
eaaac1b
to
31fd115
Compare
|
Benchmark
|
philljj
previously requested changes
Oct 29, 2024
dgarske
requested changes
Oct 29, 2024
arch.mk
Outdated
| @@ -1030,9 +1034,12 @@ ifeq ($(TARGET),sim) | |||
| LD_END_GROUP= | |||
| BOOT_IMG=test-app/image.elf | |||
| CFLAGS+=-DARCH_SIM | |||
| CFLAGS+=-DWOLFBOOT_USE_STDLIBC | |||
| LDFLAGS +=-Wl,-gc-sections -Wl,-Map=wolfboot.map | |||
There was a problem hiding this comment.
Adding these LDFLAGS breaks my ability to build and run the simulator on the Mac. Could you gate around USE_GCC perhaps?
There was a problem hiding this comment.
I guess you are referring to the -DWOLFBOOT_USE_STDLIBC. I've gated that behind USE_GCC as suggested.
There was a problem hiding this comment.
It was LDFLAGS +=-Wl,-gc-sections -Wl,-Map=wolfboot.map causing issue with MacOS.
| Key buffer size: 144 | ||
| Secondary ECC key, size: 96 | ||
| image header size overridden by config value (8192 bytes) | ||
| Creating hybrid signature |
There was a problem hiding this comment.
I tried re-building key tools 'make keytools. I am using the cp config/examples/sim-ml-dsa-ecc-hybrid.config .config `.
wolfBoot KeyTools (Compiled C version)
wolfBoot version 2020000
Parsing arguments in hybrid mode
Secondary private key: wolfboot_signing_second_private_key.der
Secondary cipher: ECC384
Version: 1
Update type: Firmware
Input image: test-app/image.elf
Selected cipher: ML-DSA
Selected hash : SHA256
Private key: wolfboot_signing_private_key.der
Secondary cipher: ECC384
Secondary private key: wolfboot_signing_second_private_key.der
Output image: test-app/image_v1_signed.bin
Target partition id : 1
info: using ML-DSA parameters: 3
error: unrecognized ml-dsa key size: 144
Key decode error -1
[MERGE] internal_flash.dd
4096+0 records in
4096+0 records out
4096 bytes transferred in 0.015564 secs (263171 bytes/sec)
make assemble_internal_flash.dd
unable to stat test-app/image_v1_signed.bin: No such file or directory
There was a problem hiding this comment.
It looks like the signing failed because the primary key is invalid (stale? created with keygen --ecc384 -g?). I cannot reproduce, it would be helpful to see what goes wrong in keys creation from make distclean make keysclean make V=1
danielinux
force-pushed
the
hybrid-auth
branch
from
671b232
to
e78755d
Compare
Removed some debug leftovers
danielinux
force-pushed
the
hybrid-auth
branch
from
e78755d
to
dbf32e6
Compare
dgarske
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.