Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Electron v6 #238

Open
vbgm opened this issue Aug 10, 2019 · 10 comments
Open

Support Electron v6 #238

vbgm opened this issue Aug 10, 2019 · 10 comments

Comments

@vbgm
Copy link

vbgm commented Aug 10, 2019

When I have electron installed greater than v4 (v5, v6) I have following error while trying to launch the app:

TypeError: electron.protocol.registerStandardSchemes is not a function
    at Object.<anonymous> (/Volumes/dev/test-meteor-desktop/.meteor/desktop-build/app/app.js:19:19)
    at Module._compile (internal/modules/cjs/loader.js:786:30)
    at Object.extWrap (/Volumes/dev/test-meteor-desktop/.meteor/desktop-build/node_modules/reify/node/compile-hook.js:53:7)
    at Object.extManager (/Volumes/dev/test-meteor-desktop/.meteor/desktop-build/node_modules/reify/node/compile-hook.js:19:12)
    at Object.manager [as .js] (/Volumes/dev/test-meteor-desktop/.meteor/desktop-build/node_modules/reify/node/wrapper.js:108:20)
    at Module.load (internal/modules/cjs/loader.js:645:32)
    at Function.Module._load (internal/modules/cjs/loader.js:560:12)
    at Module.require (internal/modules/cjs/loader.js:685:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/Volumes/dev/test-meteor-desktop/.meteor/desktop-build/app/index.js:4:1)
@darqs
Copy link
Collaborator

darqs commented Aug 11, 2019

Hello,

this issue should be fixed in next version, for now you can try test your application with https://www.npmjs.com/package/meteor-desktop-test

@evan-coygo
Copy link
Contributor

@darqs any ETA for that release?

@darqs
Copy link
Collaborator

darqs commented Sep 18, 2019

@evan-coygo I don't know when we can do it. I found some problem in meteor plugins (bundler and watcher) and I must check how to fix it.

@lacymorrow
Copy link
Contributor

Electron v7 was released a couple of weeks ago

@dorian-coygo
Copy link

@wojtkowiak or @darqs - Is there any update on when the next release will happen?

@lacymorrow
Copy link
Contributor

@darqs would you be willing to add me as a collaborator to the project?

@darqs
Copy link
Collaborator

darqs commented Jan 10, 2020

@dorian-coygo I don't know when version 2.1.0 will be released
@lacymorrow It isn't my repository

@lacymorrow
Copy link
Contributor

@wojtkowiak would you be willing to add me as a collaborator to the project?

My interest is in keeping this project alive and functional.

@LDubya
Copy link

LDubya commented Jan 12, 2020

Hi, I'm also interested in using the latest version of electron with this.

@dorian-coygo
Copy link

FYI: We started a thread to see if we can get first party support. https://forums.meteor.com/t/meteor-desktop-needs-to-have-first-party-support/51452

@KoenLav @LDubya @lacymorrow . We would love your feedback or vote on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants