Get rid of non-null assertion

wojtekmaj · Apr 17, 2024 · 702b4fd · 702b4fd
1 parent cf1dade
commit 702b4fd
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/sample/index.html b/sample/index.html
@@ -7,7 +7,7 @@
   </head>
 
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
     <script type="module" src="./index.tsx"></script>
   </body>
 </html>
diff --git a/sample/index.tsx b/sample/index.tsx
@@ -2,4 +2,10 @@ import { createRoot } from 'react-dom/client';
 
 import Sample from './Sample.js';
 
-createRoot(document.getElementById('react-root')!).render(<Sample />);
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(<Sample />);
diff --git a/test/index.html b/test/index.html
@@ -7,7 +7,7 @@
   </head>
 
   <body>
-    <div id="react-root"></div>
+    <div id="root"></div>
     <script type="module" src="./index.tsx"></script>
   </body>
 </html>
diff --git a/test/index.tsx b/test/index.tsx
@@ -3,7 +3,13 @@ import { createRoot } from 'react-dom/client';
 
 import Test from './Test.js';
 
-createRoot(document.getElementById('react-root')!).render(
+const root = document.getElementById('root');
+
+if (!root) {
+  throw new Error('Could not find root element');
+}
+
+createRoot(root).render(
   <StrictMode>
     <Test />
   </StrictMode>,