Add TODO for Finch v0.20

[jonatanklosko]

Just to be sure :D

[wojtekmach]

Thanks!

[wojtekmach]

@jonatanklosko I changed this TODO to another TODO: 520bdfe. :) I tested it with:

Mix.install([
  {:req, github: "wojtekmach/req"},
  {:finch, github: "sneako/finch", override: true},
  :bandit
])

pid = self()

spawn(fn ->
  {:ok, _} =
    Bandit.start_link(
      plug: fn conn, _ ->
        conn = Plug.Conn.send_chunked(conn, 200)
        {:ok, conn} = Plug.Conn.chunk(conn, "foo")
        raise "oops"
        conn
      end,
      port: 8080
    )

  send(pid, :ready)
  Process.sleep(:infinity)
end)

receive do
  :ready -> :ok
end

dbg(Req.get!("http://localhost:8080", retry: false, into: []))

and it seems to work but lmk if something doesn't look right.

I'm ready for next Req release, lmk if you'd like to add something before I publish it.

[jonatanklosko]

If the error happens before :status, or on a different status, then we never create the collector. So the new clause should be this:

{:error, exception, {acc, _req, _resp}} ->
  with {acc, collector} <- acc do
    collector.(acc, :halt)
  end

  {req, normalize_error(exception)}

or maybe two separate clauses:

{:error, exception, {nil, _req, _resp}} ->
  {req, normalize_error(exception)}

{:error, exception, {acc, _req, _resp}} ->
  collector.(acc, :halt)
  {req, normalize_error(exception)}

[wojtekmach]

I went with two clauses, thanks!