Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode path in url for aws_sigv4_url/1 #433

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

fahchen
Copy link
Contributor

@fahchen fahchen commented Nov 20, 2024

I encountered a SignatureDoesNotMatch when the object key contains characters that need to be escaped, such as spaces or CJK characters.

The path has been encoded at 168L, so we just update the url before returning.

path = URI.encode(url.path || "/", &(&1 == ?/ or URI.char_unreserved?(&1)))

@wojtekmach
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants