-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool size config documentation #397
Merged
wojtekmach
merged 7 commits into
wojtekmach:main
from
PragTob:pool-size-config-documentation
Dec 12, 2024
Merged
Pool size config documentation #397
wojtekmach
merged 7 commits into
wojtekmach:main
from
PragTob:pool-size-config-documentation
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wojtekmach anything I can do to help move this along? |
MrYawe
reviewed
Dec 12, 2024
Co-authored-by: Yannis Weishaupt <[email protected]>
wojtekmach
reviewed
Dec 12, 2024
wojtekmach
reviewed
Dec 12, 2024
Co-authored-by: Wojtek Mach <[email protected]>
Co-authored-by: Wojtek Mach <[email protected]>
@wojtekmach looking good! I reworded it slightly in a588da2 as |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #395 :)
Not sure if this is the best way, but I added the information I wish I'd seen yesterday and also implements a small pointer from the README. Keep me honest on that, esp. my meta note on configuration :)
Thanks! 💚