run_finch: Fix defaulting to using just HTTP/1

wojtekmach · Jun 24, 2024 · af1a34f · af1a34f
1 parent 7148e42
commit af1a34f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/lib/req.ex b/lib/req.ex
@@ -361,7 +361,7 @@ defmodule Req do
 
         * `:timeout` - socket connect timeout in milliseconds, defaults to `30_000`.
 
-        * `:protocols` - the HTTP protocols to use, defaults to `[:http1]`.
+        * `:protocols` - the HTTP protocols to use, defaults to `#{inspect(Req.Application.__default_protocols__())}`.
 
         * `:hostname` - Mint explicit hostname.
 

diff --git a/lib/req/application.ex b/lib/req/application.ex
@@ -10,7 +10,7 @@ defmodule Req.Application do
        name: Req.Finch,
        pools: %{
          default: [
-           protocols: [:http1]
+           protocols: __default_protocols__()
          ]
        }},
       {DynamicSupervisor, strategy: :one_for_one, name: Req.FinchSupervisor},
@@ -19,4 +19,8 @@ defmodule Req.Application do
 
     Supervisor.start_link(children, strategy: :one_for_one)
   end
+
+  def __default_protocols__ do
+    [:http1]
+  end
 end
diff --git a/lib/req/steps.ex b/lib/req/steps.ex
@@ -669,7 +669,7 @@ defmodule Req.Steps do
 
         * `:timeout` - socket connect timeout in milliseconds, defaults to `30_000`.
 
-        * `:protocols` - the HTTP protocols to use, defaults to `[:http1]`.
+        * `:protocols` - the HTTP protocols to use, defaults to `#{inspect(Req.Application.__default_protocols__())}`.
 
         * `:hostname` - Mint explicit hostname, see `Mint.HTTP.connect/4` for more information.
 
@@ -1086,7 +1086,7 @@ defmodule Req.Steps do
               [protocol]
 
             true ->
-              [:http1, :http2]
+              Req.Application.__default_protocols__()
           end
 
         pool_opts = [