Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added diversity, awesome traits, and added colors to graphs #9

Merged
merged 6 commits into from
Oct 22, 2021

Conversation

zestyoreo
Copy link
Contributor

Description

I have added a coder class and few more functions pertaining to traits of coders (stereotypical ones, though often true ;)

I have changed the simulations.py to accommodate more types of people when I will add them soon.

Also changed the color of each graph to look more attractive.

Motivation and Context

Diversity and better graphs!

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have read the CONTRIBUTING.md

This was linked to issues Oct 20, 2021
@Karrthik-Arya
Copy link
Collaborator

The code completes tasks 1 and 4 to add a personality and then add functions and characteristics for that type of personality. For task-2 this solves the issue of the factors exceeding 100 for some of them. However, the rate should also be a function of the current level of that factor instead of a constant increment or decrement. It can be the Gaussian function or the values of the constants can be fixed for different intervals. Also if you want you could send different PRs for different tasks/issues.

@zestyoreo
Copy link
Contributor Author

Will update accordingly.👍

@zestyoreo
Copy link
Contributor Author

Changes have been as suggested. I have used the tanh function to increase/decreate attributes.

@zestyoreo zestyoreo closed this Oct 22, 2021
@zestyoreo zestyoreo reopened this Oct 22, 2021
@Karrthik-Arya Karrthik-Arya linked an issue Oct 22, 2021 that may be closed by this pull request
@Karrthik-Arya
Copy link
Collaborator

Most of the code is fine. One small change, the change in the laziness causes an error with randint() since now the upper bound is not an integer so you can use math.floor() to sort this out. Also you can create different branches in the repo and cherry pick the commits to have there and then send separate PRs for each of the tasks. Like this you might be able to get more PRs if you are participating in hacktoberfest.

@zestyoreo
Copy link
Contributor Author

Change done. Next time I commit stuff I will make separate PRs. Thanks for the suggestions.

@Karrthik-Arya Karrthik-Arya merged commit f7cfcab into wncc:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual Interests Variation of Factors Diversity
2 participants