-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added diversity, awesome traits, and added colors to graphs #9
Conversation
The code completes tasks 1 and 4 to add a personality and then add functions and characteristics for that type of personality. For task-2 this solves the issue of the factors exceeding 100 for some of them. However, the rate should also be a function of the current level of that factor instead of a constant increment or decrement. It can be the Gaussian function or the values of the constants can be fixed for different intervals. Also if you want you could send different PRs for different tasks/issues. |
Will update accordingly.👍 |
Changes have been as suggested. I have used the tanh function to increase/decreate attributes. |
Most of the code is fine. One small change, the change in the laziness causes an error with randint() since now the upper bound is not an integer so you can use math.floor() to sort this out. Also you can create different branches in the repo and cherry pick the commits to have there and then send separate PRs for each of the tasks. Like this you might be able to get more PRs if you are participating in hacktoberfest. |
Change done. Next time I commit stuff I will make separate PRs. Thanks for the suggestions. |
Description
I have added a coder class and few more functions pertaining to traits of coders (stereotypical ones, though often true ;)
I have changed the simulations.py to accommodate more types of people when I will add them soon.
Also changed the color of each graph to look more attractive.
Motivation and Context
Diversity and better graphs!
Review Time Estimate
Types of changes
Checklist: