Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New variables for the codetable 1-01-01.csv #169

Closed
richard-olav opened this issue May 25, 2020 · 10 comments
Closed

New variables for the codetable 1-01-01.csv #169

richard-olav opened this issue May 25, 2020 · 10 comments
Assignees
Labels
addition branch Discussion required This issues should be checked and discussed by TT-WMD.
Milestone

Comments

@richard-olav
Copy link

richard-olav commented May 25, 2020

I am not able to find the representations for the variables below in the codetable 1-01-01.csv Observed variable - measurand (atmosphere):

EBAS variable name, cf_name,matrix
calcium,mass_concentration_of_calcium_in_pm10_minus_pm1_in_air,pm10_pm1
calcium,mass_concentration_of_calcium_in_pm10_minus_pm2p5_in_air,pm10_pm25

Could they be added?

@IgorZahumensky
Copy link

@joergklausen - ditto as 168

@joergklausen
Copy link
Contributor

Franziska: needs a Proposal and Reason, and branch with new entries along the lines of what we already have. It is clear that we will review the structure of the table more holistically, but adding new variables is more achievable right now.

@fstuerzl
Copy link
Member

Summary and Purpose
Addition of variables for calcium in code table 1-01-01 (Observed variable - atmosphere)

Proposal
Include the following variables in code table 1-01-01.csv

Label Description Path
Calcium  (Ca++), PM10-PM1, in air Mass concentration of calcium in PM10-PM1 in air \Atmosphere\Aerosol\Composition\Inorganic cations\Calcium  (Ca++), PM10-PM1, in air
Calcium  (Ca++), PM10-PM2.5, in air Mass concentration of calcium in PM10-PM2.5 in air \Atmosphere\Aerosol\Composition\Inorganic cations\Calcium  (Ca++), PM10-PM2.5, in air

Reason
Missing entries in variable list, required by @richard-olav

@fstuerzl
Copy link
Member

fstuerzl commented Jan 5, 2021

@fstuerzl fstuerzl added the branch label Jan 5, 2021
@fstuerzl
Copy link
Member

fstuerzl commented Jan 5, 2021

Path structure and variable modifiers depend on #173 and #181.
@richard-olav, @gaochen-larc, @markusfiebig, could you state your opinion on whether these variables should be added before reorganising the aerosol branch?

@fstuerzl fstuerzl added the Discussion required This issues should be checked and discussed by TT-WMD. label Jan 5, 2021
@markusfiebig
Copy link
Collaborator

@fstuerzl, I'm a little confused about the proposed names. Just before Christmas, we had a telecon where we found ways to store modifiers like PM1, PM10, etc. in WMDS elements outside the variable name to prevent the list of variables from blowing up. We also agreed that the way forward would be to store these modifiers not in the variable names, but other places in the metadata record. If we now define names that include modifiers, we are locked in, or we need to change them again very soon. I would propose to leave these out.

@fstuerzl
Copy link
Member

fstuerzl commented Jan 8, 2021

@markusfiebig, I agree that with the changes, we discussed, these variables will be obsolete. I am however not sure how long it will take until a new approach to store modifiers is approved and implemented. Therefore I think, it needs to be discussed, whether it makes sense to add the variables @richard-olav requested for now if they are needed urgently.
The same applies to issue #168 and #170.

@richard-olav
Copy link
Author

@fstuerzl, for me, there is no urgent need for these specific variables. So I agree with you and Markus that it could wait until the new approach related to storing modifiers is approved and implemented. This would then also be the case for issue #168 and #170. Thanks.

@gaochen-larc
Copy link
Contributor

@fstuerzl @markusfiebig I agree with both of you. Thanks!

@fstuerzl
Copy link
Member

@richard-olav, @gaochen-larc, @markusfiebig, thanks for your reviews! In this case issues #168, #169, #170 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition branch Discussion required This issues should be checked and discussed by TT-WMD.
Projects
None yet
Development

No branches or pull requests

7 participants