Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overestimated border length and vertex counts #20

Open
karimbahgat opened this issue Jul 22, 2021 · 1 comment
Open

Fix overestimated border length and vertex counts #20

karimbahgat opened this issue Jul 22, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@karimbahgat
Copy link
Collaborator

Currently, the total border length/circumference and the vertex count per source is calculated as the sum total for all admin units. However, since admin units share borders this ends up double counting border length and vertices for all internal borders and thus overestimating their numbers.

As a solution, loop through each feature, convert to multilinestring, then add to a cumulative multiline union of all admin outlines. Then calculate length and vertices on that single cumulative multiline geometry.

@karimbahgat karimbahgat added the bug Something isn't working label Jul 22, 2021
@DanRunfola
Copy link
Member

DanRunfola commented Jul 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants