Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf: module-monitoring-19 Group ES metrics by cluster #1095

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

tarrow
Copy link
Contributor

@tarrow tarrow commented Aug 14, 2023

Grouping by elasticsearch cluster should ensure that there are not erroneous alerts fired about a loss of metric series when the identity of the exporter pod changes

Grouping by elasticsearch cluster should ensure that there are not
erroneous alerts fired about a loss of metric series when the
identity of the exporter pod changes
Copy link
Contributor

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an established workflow for creating such a "tagged release" for a tf module? Asking because I'd have included the changelog update in this PR, but then again I might be missing something.

@tarrow
Copy link
Contributor Author

tarrow commented Aug 14, 2023

we don't but probably we should. In any case the lack of changelog here is oversight by me anyway (i'd written it but failed to stage it)

@tarrow tarrow merged commit a424749 into main Aug 14, 2023
2 checks passed
@tarrow tarrow deleted the aggregateESAlerts branch August 14, 2023 14:49
deer-wmde pushed a commit that referenced this pull request Aug 15, 2023
* tf: module-monitoring-19 Group ES metrics by cluster

Grouping by elasticsearch cluster should ensure that there are not
erroneous alerts fired about a loss of metric series when the
identity of the exporter pod changes

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants