Merge pull request #210 from wmde/postcode-length

Donation/Membership form postcode maximum field length validation

config/DoctrineClassMapping/WMDE.Fundraising.MembershipContext.DataAccess.DoctrineEntities.MembershipApplication.dcm.xml

@@ -39,7 +39,7 @@
       </options>
     </field>
     <field name="address" type="string" column="strasse" length="100" nullable="true"/>
-    <field name="postcode" type="string" column="plz" length="8" nullable="true"/>
+    <field name="postcode" type="string" column="plz" length="16" nullable="true"/>
     <field name="city" type="string" column="ort" length="100" nullable="true"/>
     <field name="country" type="string" column="country" length="8" nullable="true">
       <options>

src/DataAccess/Migrations/Version20240826150940.php

@@ -0,0 +1,22 @@
+<?php
+
+declare( strict_types=1 );
+
+namespace WMDE\Fundraising\MembershipContext\DataAccess\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+final class Version20240826150940 extends AbstractMigration {
+	public function getDescription(): string {
+		return 'Increase postcode length to 16';
+	}
+
+	public function up( Schema $schema ): void {
+		$schema->getTable( 'request' )->getColumn( 'plz' )->setLength( 16 );
+	}
+
+	public function down( Schema $schema ): void {
+		$schema->getTable( 'request' )->getColumn( 'plz' )->setLength( 8 );
+	}
+}

src/UseCases/ApplyForMembership/MembershipApplicationValidator.php

@@ -28,7 +28,7 @@ class MembershipApplicationValidator {
 		Result::SOURCE_APPLICANT_LAST_NAME => 50,
 		Result::SOURCE_APPLICANT_SALUTATION => 16,
 		Result::SOURCE_APPLICANT_STREET_ADDRESS => 100,
-		Result::SOURCE_APPLICANT_POSTAL_CODE => 8,
+		Result::SOURCE_APPLICANT_POSTAL_CODE => 16,
 		Result::SOURCE_APPLICANT_CITY => 100,
 		Result::SOURCE_APPLICANT_COUNTRY => 8,
 	];