Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of vt port from Bill-Gray #150

Open
GitMensch opened this issue Aug 13, 2023 · 1 comment
Open

addition of vt port from Bill-Gray #150

GitMensch opened this issue Aug 13, 2023 · 1 comment

Comments

@GitMensch
Copy link
Contributor

https://github.com/Bill-Gray/PDCursesMod/tree/master/vt

That one would be quite useful to have a "more portable" option to run the same port on different terminals on different OS.
I don't remember a general issue that would hinder the integration (other than some changed defaults, but those should mostly reside in the pdcurses folder which likely don't need much changes for that integration).

@wmcbrine Any thoughts about that? Would you likely integrate a big PR to "just get that in" (I'd try to do that with git filter-branch --subdirectory-filter vt to get all changes in the folder in, then merge single changes to the pdcurses folder where reasonable / do separate commit(s) to add the necessary glue)?

@Bill-Gray Do you see any general issues with that?

@Bill-Gray
Copy link
Contributor

@GitMensch - I'll leave the desirability of doing this to you and William. I'd be inclined to say that if you wanted the VT (or various other ports), you could just use PDCursesMod, and I could imagine William being of the same opinion.

If it were deemed desirable, though, I think this would be doable with only minor surgery on the code... except possibly for the color handling. That bit could take some effort. And there may be other bits and bobs that would trip you up; PDCurses and PDCursesMod really have drifted apart a bit in recent years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants