Add support for Server-Side Encryption via AWS Key Management Service (KMS) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muteor
requested changes
Sep 16, 2016
| if (bucket == null || bucket == "") { | ||
| throw new ConnectException("S3 bucket must be configured"); | ||
| } | ||
| if (prefix == null) { | ||
| prefix = ""; | ||
| } | ||
|
|
||
| String s3Region = config.get(S3SinkConnectorConstants.S3_REGION_CONFIG); |
There was a problem hiding this comment.
Whats the default here? We probably want this to be optional, so dont set the region if there is not a config key.
| import com.amazonaws.services.s3.model.PutObjectRequest; | ||
| import com.amazonaws.services.s3.model.S3Object; | ||
| import com.amazonaws.services.s3.model.S3ObjectInputStream; | ||
| import com.amazonaws.services.s3.model.*; |
There was a problem hiding this comment.
Would prefer to keep explicit deps please.
| import java.io.IOException; | ||
| import java.io.Reader; | ||
| import java.lang.StringBuilder; | ||
| import java.io.*; |
iamnoah
added a commit
to iamnoah/kafka-connect-s3
that referenced
this pull request
Dec 11, 2020
S3 Source and Systemic Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.