Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searchable selects, improve selects accessibility #370

Merged
merged 11 commits into from
Nov 17, 2024

Conversation

louisescher
Copy link
Member

Description

  • Adds a searchable select component with keyboard controls.
  • Improves the keyboard accessibility for normal selects.

@louisescher louisescher self-assigned this Oct 30, 2024
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 7d9dfca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@studiocms/ui Patch
studiocms Patch
@studiocms/assets Patch
@studiocms/auth Patch
@studiocms/betaresources Patch
@studiocms/core Patch
@studiocms/dashboard Patch
@studiocms/devapps Patch
@studiocms/frontend Patch
@studiocms/imagehandler Patch
@studiocms/renderers Patch
@studiocms/robotstxt Patch
@studiocms/blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

1 similar comment
@studiocms-no-reply
Copy link
Member

Thank you for submitting your Pull Request, the following links will become available for preview shortly:

@louisescher

This comment was marked as outdated.

@louisescher louisescher marked this pull request as ready for review October 30, 2024 23:04
Copy link

studio-cms-deployments bot commented Oct 30, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-10-31 10:44:39 CET

Copy link

studio-cms-deployments bot commented Oct 30, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-10-31 10:48:46 CET

@Adammatthiesen Adammatthiesen added documentation Improvements or additions to documentation awaiting review(s) labels Oct 30, 2024
jdtjenkins

This comment was marked as resolved.

@louisescher

This comment was marked as resolved.

Adammatthiesen

This comment was marked as resolved.

Copy link

studio-cms-deployments bot commented Nov 2, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-11-04 02:00:29 CET

Copy link

studio-cms-deployments bot commented Nov 2, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-11-04 01:28:41 CET

@Adammatthiesen
Copy link
Member

Adammatthiesen commented Nov 4, 2024

image
When i select one of the options on the searchable shouldn't it also change the text-color? Basically once a selected option is hit shouldn't it look like the regular select? since it has a selected option?

@louisescher
Copy link
Member Author

image When i select one of the options on the searchable shouldn't it also change the text-color? Basically once a selected option is hit shouldn't it look like the regular select? since it has a selected option?

I think if I were to do that you'd get confused about whether you've got something typed in atm or if it's the thing you've selected

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments about note usage, otherwise lgtm!

@TheOtterlord TheOtterlord merged commit 7c61211 into issue-0304 Nov 17, 2024
1 check passed
@TheOtterlord TheOtterlord deleted the searchable-selects branch November 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants