Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add links to "Open a PR" on resources pages (plugins.mdx & community-content.mdx) #2580

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

trueberryless
Copy link
Contributor

Description

I'm not sure if the maintainers want these changes to exist, because it kinda feels intended that the "Call to action" sections have no links on both sites but on the showcase.mdx site it does.
Probably the reason is, that we want people to add their Showcases on their own, but Plugins and other Content is maybe to complex for the people, so they should just provide a link and we change the files on our own. But I don't know and therefore I through this PR in here...

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 8214e5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trueberryless trueberryless changed the title Feat: Add links to "Open a PR" on resources pages (plugins.mdx & community-content.,mdx) Feat: Add links to "Open a PR" on resources pages (plugins.mdx & community-content.mdx) Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 8214e5e
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/672bbe0f62a745000898b4fd
😎 Deploy Preview https://deploy-preview-2580--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 6, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Nov 6, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en resources/community-content.mdx Source changed, localizations will be marked as outdated.
en resources/plugins.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor Author

Also I'll move the misplaced import statement to another PR cause it doesn't have to do anything with this one...

CONTRIBUTING.md Outdated Show resolved Hide resolved
@trueberryless trueberryless marked this pull request as draft November 6, 2024 18:44
@trueberryless trueberryless marked this pull request as ready for review November 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants