-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JRuby fails to bundle #11
Comments
Hi Adrian, That's unfortunate. It's because of the dependency on nsq-cluster for testing. Ironically we moved to sys-proctable there for get better cross platform support (see: wistia/nsq-cluster@e46160d). Looks like sys-proctable isn't planning to support JRuby anytime soon: djberg96/sys-proctable#18. Any ideas for how to get around this? PR's welcome, of course! Brendan |
I'll give it a try. My initial idea is to remove the hard dependency, already in my fork, and then in the tests check if it can be loaded. If it can't then display a warning and skip that test. Now I haven't checked if you can run any of the tests without it. What do you think? |
I think that sounds reasonable. It might be easier to try to do this at the nsq-cluster level though. We need nsq-cluster for pretty much all the nsq-ruby tests. But nsq-cluster just needs sys-proctable for stopping nsqadmin, which none of these tests really need. Hmm, this is a tricky problem :) |
Hmh, it seems then that we need to change the hard requirement at nsq-cluster and follow the whining idea when you try to stop nsqadmin? Basically try to load sys-proctable when you actually try to stop nsqadmin and raise the exception there. Or add a warning message at nsq-cluster load time and also raise the exception? |
Created this PR for nsq-cluster: Please let me know what you think. |
When bundling in JRuby for development it fails because of sys-proctable
The text was updated successfully, but these errors were encountered: