Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Sent Events - how to handle asking for an event that doesn't exist #20

Open
danjenkins opened this issue Oct 16, 2024 · 6 comments

Comments

@danjenkins
Copy link

How do you know what events a WHEP server supports? Is there a discovery path that will list whats supported by the server somewhere?

I don't see anything in the current draft version that says "you asked for layers events but we don't support it... so return a 4xx to the POST request"

WHEP is meant to be generic, so being able to know what events a server may accept programatically is important

@danjenkins danjenkins changed the title Server Sent Events Server Sent Events - discovery/failure Oct 16, 2024
@murillo128
Copy link
Collaborator

it is in the Link header with the sse url

Link: <https://whep.ietf.org/resource/213786HF/sse>;
      rel="urn:ietf:params:whep:ext:core:server-sent-events"
      events="active,inactive,layers,reconnect,viewercount,scte35"

@danjenkins
Copy link
Author

Ah! I'd completely missed that, thanks!

What about what happens when you ask for something sse/events endpoint doesnt support?

@murillo128
Copy link
Collaborator

It is up to the server to decide if it rejects the request or ignore the event. Not sure if we need to explicity specify what to do with misbehaving clients

@danjenkins
Copy link
Author

@murillo128 I don't understand that, isn't the point of a spec to say "this is how the server should behave" ? If I request something that isn't supported surely it should fail and tell me "you're not going to get that event because we don't support it" ?

@murillo128
Copy link
Collaborator

My point of view is, if the client MUST send a subset of the events provided by the server, then this case is outside of the spec, and HTTP directorate has prevented us for redefining http behaviour. That's why I am not sure if we should cover how to handle non-compliant clients or not.

@danjenkins
Copy link
Author

So just following on after watching the session online, this needs a PR to add detail on that failure scenario. Is this something you want to add @murillo128 ? Or do you want someone else to do that?

@danjenkins danjenkins changed the title Server Sent Events - discovery/failure Server Sent Events - how to handle asking for an event that doesn't exist Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants