-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change a key for the dependency cache - WPB-14445 #2180
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2ac70e4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change it to false as it makes more sense, no DD for tests at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Issue
We create a key for the cache when building the app as:
hash(Package.resolved)-ENABLE_DATADOG
But for tests we can hardcode the value of
ENABLE_DATADOG
, and this will allow the cache to be reused.Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: