Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change a key for the dependency cache - WPB-14445 #2180

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Nov 21, 2024

BugWPB-14445 [iOS] Change a key for dependencies cache

Issue

We create a key for the cache when building the app as: hash(Package.resolved)-ENABLE_DATADOG
But for tests we can hardcode the value of ENABLE_DATADOG, and this will allow the cache to be reused.

Testing


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 2ac70e4.

♻️ This comment has been updated with latest results.

.github/workflows/_reusable_run_tests.yml Outdated Show resolved Hide resolved
@KaterinaWire KaterinaWire changed the title feat: Change a key for the dependency cache -WPB-14445 feat: Change a key for the dependency cache - WPB-14445 Nov 21, 2024
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change it to false as it makes more sense, no DD for tests at all

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@KaterinaWire KaterinaWire added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 592c9fe Nov 26, 2024
12 checks passed
@KaterinaWire KaterinaWire deleted the fix/cache-key-for-tests branch November 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants