refactor: conversation message timer update event - WPB-10171 #2098
+627
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullianm
commented
Oct 29, 2024
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Oct 29, 2024
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Oct 29, 2024
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationRepository.swift
Show resolved
Hide resolved
netbe
reviewed
Nov 5, 2024
…tory, add UTs, clean up code - WPB-10171 (#2098)
jullianm
commented
Nov 26, 2024
| messageType: messageType, | ||
| conversationID: conversationID.uuid, | ||
| conversationDomain: conversationID.domain | ||
| ) |
There was a problem hiding this comment.
some updates introduces in this PR, now that the MessageRepository is merged, I've added a MessageType case to handle the timer update message through the dedicated repository.
Test Results 3 files 326 suites 3m 21s ⏱️ Results for commit 768b81b. |
johnxnguyen
reviewed
Nov 27, 2024
...ent Processing/ConversationEventProcessor/ConversationMessageTimerUpdateEventProcessor.swift
Outdated
Show resolved
Hide resolved
...ent Processing/ConversationEventProcessor/ConversationMessageTimerUpdateEventProcessor.swift
Outdated
Show resolved
Hide resolved
...ent Processing/ConversationEventProcessor/ConversationMessageTimerUpdateEventProcessor.swift
Show resolved
Hide resolved
...ent Processing/ConversationEventProcessor/ConversationMessageTimerUpdateEventProcessor.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
ConversationMessageTimerUpdateevent.Testing
UTs cover the following use cases, ensuring that
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: