Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move WireLogger into WireFoundation - WPB-11881 #1938

Draft
wants to merge 329 commits into
base: develop
Choose a base branch
from
Draft

chore: move WireLogger into WireFoundation - WPB-11881 #1938

wants to merge 329 commits into from
+509 −12,393

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 16, 2024 •
edited by github-actions bot
Loading

StoryWPB-10941 Create WireFoundation package combining WireSystem, WireUtilities and WireTesting

Issue

In order to be able to use logging from WireFoundation the Wire Logger must be declared here.
This PR moves all files except WireLoggerObjC to WireFoundation.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian
move project WireDomain
94ed28b
@caldrian
fix linking WireAPI
b1a95ef
@caldrian
update projects
0a05c3e
@caldrian
merge WireDomain directories
b819d15
@caldrian
rename projects
db5c566
@caldrian
fix directory structure for WireSystem
48716df
@caldrian
fix directory structure for WireUtilities
0192d95
@caldrian
fix directory structure for WireTesting
e812ace
@caldrian
fix workspace
618025d
@caldrian
fix workflow definitions
2532bd7
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/move…
1e065f9 
…-WireUITesting-into-separate-package-WPB-7306
@caldrian
fix paths
6bd5549
@caldrian
fix workflow definition
efd45a0
@caldrian
format code
fa2f1d5
@caldrian
fix scheme WireSystem
6603bf5
@caldrian
Pkg suffix
957ee59
@caldrian
link WireTesting into Wire-iOS
8211577
@caldrian
fix symlinks
2982972
@caldrian
fix testplans
70a850d
@caldrian
dont retry
94d9024
@caldrian
fix WireDomain test plan
ef2d3d0
@caldrian
fix workflow definition
093be86
@caldrian
link packages
b4cc10c
@caldrian
fix sourcery.yml
b48af27
@caldrian
remove wrong dependency
4f03898
@caldrian
fix build error
4178ef4
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/move…
d13db9e 
…-WireUITesting-into-separate-package-WPB-7306
@caldrian
delete type argument
75cde3e
@caldrian
Revert "delete type argument"
b150369 
This reverts commit 75cde3e.
@caldrian
fix dynamic WireAPI linking
f563c10
@caldrian caldrian changed the base branch from release/cycle-3.114 to fix/sourcery-stencils-WPB-11881 November 22, 2024 14:55
Base automatically changed from fix/sourcery-stencils-WPB-11881 to release/cycle-3.114 November 22, 2024 15:34
caldrian and others added 9 commits November 22, 2024 16:55
@caldrian
fix: showing/hiding empty conversation list placeholder - WPB-14386 (#…
fe83965 
…2179)
@caldrian
fix: network status view background color - WPB-14466 (#2189)
234e41d
@samwyndham
fix: Image selector anchor - WPB-11605 (#2100)
1611386
@caldrian
fix: status bar appearance on iPad - WPB-14474 (#2191)
47d5011
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
86f9ba2 
…o chore/move-WireLogger-into-WireFoundation-WPB-10941

# Conflicts:
#	wire-ios-system/Source/ZMSLog.swift
#	wire-ios-system/WireSystem.xcodeproj/project.pbxproj
@samwyndham
fix: Applied filter view height - WPB-14421 (#2188)
af3ecdc
@samwyndham
fix: Move to folder picker tappable area - WPB-14469 (#2197)
166d69e
@samwyndham
fix: Nav bar covers content in Guest & Services views - WPB-14452 (#2202
bd8e650 
)
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
12a4c89 
…o chore/move-WireLogger-into-WireFoundation-WPB-10941
@caldrian caldrian marked this pull request as ready for review November 26, 2024 09:44
@caldrian caldrian marked this pull request as draft November 26, 2024 09:44
@netbe netbe changed the base branch from release/cycle-3.114 to develop November 28, 2024 13:45
@echoes-hq echoes-hq bot added echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@caldrian caldrian

Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caldrian @netbe @samwyndham @KaterinaWire