Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: map correct branch to wire-builds #5089

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Nov 7, 2024

Description

The branch name and tags used to map the correct account release to wire-build was based on the name of webapp branches and does not correspond to the account repo.

Changes

  • map the main wire-account branch to the main wire-build branch (previously was mapping a production tag that doesn't exist on wire-account)
  • map the staging wire-account branch to the dev wire-build branch (wira-account staging branch is used in dev environments and not with production backends)

@V-Gira V-Gira requested a review from smatting November 7, 2024 13:14
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Coverage Report

Totals Coverage
Statements: 28.54% ( 341 / 1195 )
Methods: 22.44% ( 35 / 156 )
Lines: 30.96% ( 257 / 830 )
Branches: 23.44% ( 49 / 209 )

StandWithUkraine

Copy link
Collaborator

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there is no "dev" branch in wire-account. Other than that the config looks plusible

@V-Gira V-Gira merged commit dfeea2c into staging Nov 7, 2024
9 checks passed
@V-Gira V-Gira deleted the v/account-wire-builds branch November 7, 2024 13:25
@paulwire paulwire added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants