feat(remove-mls-data-on-device-being-removed) #WPB-12155 #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When removing a Device from Legalhold, we weren't removing MLS data (if MLS is enabled and user exists)
Causes (Optional)
Not implemented.
Solutions
Add verification if user exists and if MLS is enabled when calling
removeDevice
fromDeviceManagementService
then callingCryptoMlsClient.wipe()
Dependencies (Optional)
Xenon 1.7.2
Helium 1.5.2
Testing
Test Coverage (Optional)
Notes
We have a manual implementation to remove MLS data from Xenon for now until
CoreCrypto
releases a fix forCoreCrypto.wipe()
function, the progress can be seen from #WPB-14514