Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-mls-data-on-device-being-removed) #WPB-12155 #33

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

alexandreferris
Copy link
Contributor

  • Update README.md to include CORE_CRYPTO_PASSWORD
  • Add call to Xenon CryptoMlsClient wipe() function in removeDevice
  • Add tests for wipe mls data on device removed

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When removing a Device from Legalhold, we weren't removing MLS data (if MLS is enabled and user exists)

Causes (Optional)

Not implemented.

Solutions

Add verification if user exists and if MLS is enabled when calling removeDevice from DeviceManagementService then calling CryptoMlsClient.wipe()

Dependencies (Optional)

Xenon 1.7.2
Helium 1.5.2

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Notes

We have a manual implementation to remove MLS data from Xenon for now until CoreCrypto releases a fix for CoreCrypto.wipe() function, the progress can be seen from #WPB-14514

* Update README.md to include CORE_CRYPTO_PASSWORD
* Add call to CoreCrypto wipe() function in removeDevice
* Add tests for wipe mls data on device removed
@alexandreferris alexandreferris self-assigned this Nov 27, 2024
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud labels Nov 27, 2024
* Add Crypto mocked object to remove unnecessary try/catches
Copy link

sonarcloud bot commented Nov 28, 2024

@alexandreferris alexandreferris merged commit 65f8b75 into staging Nov 28, 2024
5 checks passed
@alexandreferris alexandreferris deleted the WPB-12155 branch November 28, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants