Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include the message of the source error when bundling errors together [WPB-14614] #787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

typfel
Copy link
Member

@typfel typfel commented Nov 28, 2024

What's new in this PR

We started to bundle together errors which clients can't act upon, but it's still useful to include source error message for debugging purposes.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel typfel requested a review from a team as a code owner November 28, 2024 16:08
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 28, 2024
Copy link

🐰 Bencher Report

Branchfeat/include-error-cause-WPB-14614
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18,898,000.00
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,771,200.00
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9,336,100.00
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,724,000.00
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14,756,000.00
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
17,023,000.00
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
982,310,000.00
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6,897,100.00
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84,086,000.00
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
220,080,000.00
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
424,880,000.00
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
672,580,000.00
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115,530,000.00
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28,341,000.00
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45,892,000.00
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60,658,000.00
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
78,903,000.00
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
94,735,000.00
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18,946,000.00
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
114,820,000.00
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
36,769,000.00
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56,541,000.00
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75,516,000.00
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95,878,000.00
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
27,848,000.00
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,720,600.00
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8,711,600.00
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12,143,000.00
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17,575,000.00
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22,276,000.00
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30,578,000.00
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
136,310,000.00
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
114,510,000.00
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93,057,000.00
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
72,169,000.00
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
51,410,000.00
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
136,120,000.00
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,869,100.00
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33,607,000.00
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
58,840,000.00
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
85,833,000.00
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
111,180,000.00
Count KeyPackage/cs1/mem/1002📈 view plot
🚷 view threshold
10,038,000.00
Count KeyPackage/cs1/mem/2📈 view plot
🚷 view threshold
6,437,400.00
Count KeyPackage/cs1/mem/202📈 view plot
🚷 view threshold
6,912,400.00
Count KeyPackage/cs1/mem/402📈 view plot
🚷 view threshold
7,741,700.00
Count KeyPackage/cs1/mem/602📈 view plot
🚷 view threshold
9,033,800.00
Count KeyPackage/cs1/mem/802📈 view plot
🚷 view threshold
9,489,200.00
Create group/cs1/mem📈 view plot
🚷 view threshold
6,390,300.00
Decrypt f(msg size)/cs1/mem/10📈 view plot
🚷 view threshold
6,183,800.00
Decrypt f(msg size)/cs1/mem/10010📈 view plot
🚷 view threshold
6,346,600.00
Decrypt f(msg size)/cs1/mem/2010📈 view plot
🚷 view threshold
6,249,300.00
Decrypt f(msg size)/cs1/mem/4010📈 view plot
🚷 view threshold
6,265,400.00
Decrypt f(msg size)/cs1/mem/6010📈 view plot
🚷 view threshold
6,248,800.00
Decrypt f(msg size)/cs1/mem/8010📈 view plot
🚷 view threshold
6,260,100.00
Encrypt f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
8,670,500.00
Encrypt f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,303,600.00
Encrypt f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
6,873,600.00
Encrypt f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
7,495,600.00
Encrypt f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
7,555,900.00
Encrypt f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
8,426,500.00
Encrypt f(msg size)/cs1/mem/10📈 view plot
🚷 view threshold
8,540,200.00
Encrypt f(msg size)/cs1/mem/10010📈 view plot
🚷 view threshold
8,691,800.00
Encrypt f(msg size)/cs1/mem/2010📈 view plot
🚷 view threshold
8,870,300.00
Encrypt f(msg size)/cs1/mem/4010📈 view plot
🚷 view threshold
8,676,700.00
Encrypt f(msg size)/cs1/mem/6010📈 view plot
🚷 view threshold
8,883,200.00
Encrypt f(msg size)/cs1/mem/8010📈 view plot
🚷 view threshold
8,723,600.00
Generate KeyPackage f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
244,280,000.00
Generate KeyPackage f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,464,400.00
Generate KeyPackage f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
32,952,000.00
Generate KeyPackage f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
86,001,000.00
Generate KeyPackage f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
138,120,000.00
Generate KeyPackage f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
191,260,000.00
Join from external commit f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
245,830,000.00
Join from external commit f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7,481,500.00
Join from external commit f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
55,246,000.00
Join from external commit f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
103,460,000.00
Join from external commit f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
151,550,000.00
Join from external commit f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
199,680,000.00
Join from welcome f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
112,020,000.00
Join from welcome f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7,119,200.00
Join from welcome f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
28,094,000.00
Join from welcome f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
49,152,000.00
Join from welcome f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
70,737,000.00
Join from welcome f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
91,389,000.00
Mls vs Proteus: add/MLS/mem/1📈 view plot
🚷 view threshold
6,881,500.00
Mls vs Proteus: add/MLS/mem/101📈 view plot
🚷 view threshold
8,123,200.00
Mls vs Proteus: add/MLS/mem/21📈 view plot
🚷 view threshold
7,078,200.00
Mls vs Proteus: add/MLS/mem/41📈 view plot
🚷 view threshold
7,271,600.00
Mls vs Proteus: add/MLS/mem/61📈 view plot
🚷 view threshold
7,619,000.00
Mls vs Proteus: add/MLS/mem/81📈 view plot
🚷 view threshold
7,916,600.00
Mls vs Proteus: add/Proteus/mem/1📈 view plot
🚷 view threshold
6,479,200.00
Mls vs Proteus: add/Proteus/mem/101📈 view plot
🚷 view threshold
44,387,000.00
Mls vs Proteus: add/Proteus/mem/21📈 view plot
🚷 view threshold
14,074,000.00
Mls vs Proteus: add/Proteus/mem/41📈 view plot
🚷 view threshold
21,803,000.00
Mls vs Proteus: add/Proteus/mem/61📈 view plot
🚷 view threshold
29,264,000.00
Mls vs Proteus: add/Proteus/mem/81📈 view plot
🚷 view threshold
36,807,000.00
Mls vs Proteus: encrypt/MLS/mem/1📈 view plot
🚷 view threshold
6,372,900.00
Mls vs Proteus: encrypt/MLS/mem/101📈 view plot
🚷 view threshold
6,779,100.00
Mls vs Proteus: encrypt/MLS/mem/21📈 view plot
🚷 view threshold
6,506,600.00
Mls vs Proteus: encrypt/MLS/mem/41📈 view plot
🚷 view threshold
6,479,400.00
Mls vs Proteus: encrypt/MLS/mem/61📈 view plot
🚷 view threshold
6,697,800.00
Mls vs Proteus: encrypt/MLS/mem/81📈 view plot
🚷 view threshold
6,648,300.00
Mls vs Proteus: encrypt/Proteus/mem/1📈 view plot
🚷 view threshold
6,154,300.00
Mls vs Proteus: encrypt/Proteus/mem/101📈 view plot
🚷 view threshold
16,121,000.00
Mls vs Proteus: encrypt/Proteus/mem/21📈 view plot
🚷 view threshold
8,643,900.00
Mls vs Proteus: encrypt/Proteus/mem/41📈 view plot
🚷 view threshold
10,105,000.00
Mls vs Proteus: encrypt/Proteus/mem/61📈 view plot
🚷 view threshold
12,182,000.00
Mls vs Proteus: encrypt/Proteus/mem/81📈 view plot
🚷 view threshold
13,883,000.00
Mls vs Proteus: remove/MLS/mem/1📈 view plot
🚷 view threshold
20,056,000.00
Mls vs Proteus: remove/MLS/mem/101📈 view plot
🚷 view threshold
8,300,300.00
Mls vs Proteus: remove/MLS/mem/21📈 view plot
🚷 view threshold
17,654,000.00
Mls vs Proteus: remove/MLS/mem/41📈 view plot
🚷 view threshold
15,371,000.00
Mls vs Proteus: remove/MLS/mem/61📈 view plot
🚷 view threshold
12,963,000.00
Mls vs Proteus: remove/MLS/mem/81📈 view plot
🚷 view threshold
10,674,000.00
Mls vs Proteus: remove/Proteus/mem/1📈 view plot
🚷 view threshold
6,022,700.00
Mls vs Proteus: remove/Proteus/mem/101📈 view plot
🚷 view threshold
7,201,800.00
Mls vs Proteus: remove/Proteus/mem/21📈 view plot
🚷 view threshold
6,413,900.00
Mls vs Proteus: remove/Proteus/mem/41📈 view plot
🚷 view threshold
6,576,400.00
Mls vs Proteus: remove/Proteus/mem/61📈 view plot
🚷 view threshold
6,713,500.00
Mls vs Proteus: remove/Proteus/mem/81📈 view plot
🚷 view threshold
7,116,700.00
Mls vs Proteus: update/MLS/mem/1📈 view plot
🚷 view threshold
7,178,700.00
Mls vs Proteus: update/MLS/mem/101📈 view plot
🚷 view threshold
20,058,000.00
Mls vs Proteus: update/MLS/mem/21📈 view plot
🚷 view threshold
9,621,600.00
Mls vs Proteus: update/MLS/mem/41📈 view plot
🚷 view threshold
12,264,000.00
Mls vs Proteus: update/MLS/mem/61📈 view plot
🚷 view threshold
14,869,000.00
Mls vs Proteus: update/MLS/mem/81📈 view plot
🚷 view threshold
17,529,000.00
Mls vs Proteus: update/Proteus/mem/1📈 view plot
🚷 view threshold
6,374,700.00
Mls vs Proteus: update/Proteus/mem/101📈 view plot
🚷 view threshold
46,216,000.00
Mls vs Proteus: update/Proteus/mem/21📈 view plot
🚷 view threshold
14,843,000.00
Mls vs Proteus: update/Proteus/mem/41📈 view plot
🚷 view threshold
22,351,000.00
Mls vs Proteus: update/Proteus/mem/61📈 view plot
🚷 view threshold
30,429,000.00
Mls vs Proteus: update/Proteus/mem/81📈 view plot
🚷 view threshold
38,082,000.00
🐰 View full continuous benchmarking report in Bencher

…gether [WPB-14614]

We started to bundle together errors which clients can't act upon, but it's still useful
to include source error message for debugging purposes.
@typfel typfel force-pushed the feat/include-error-cause-WPB-14614 branch from 755a113 to 5e885d7 Compare November 29, 2024 15:20
Copy link

github-actions bot commented Nov 29, 2024

🐰 Bencher Report

Branchfeat/include-error-cause-WPB-14614
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18,547,000.00
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,746,800.00
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9,183,900.00
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,988,000.00
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14,650,000.00
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16,521,000.00
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
974,760,000.00
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6,713,900.00
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
83,794,000.00
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
218,660,000.00
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
421,100,000.00
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
669,180,000.00
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115,150,000.00
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28,214,000.00
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45,682,000.00
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60,753,000.00
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79,131,000.00
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
93,846,000.00
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18,452,000.00
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
114,290,000.00
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35,618,000.00
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56,358,000.00
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
74,995,000.00
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
94,707,000.00
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
27,377,000.00
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,575,700.00
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8,712,400.00
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,983,000.00
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17,246,000.00
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22,089,000.00
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30,127,000.00
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
135,990,000.00
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
114,150,000.00
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
92,930,000.00
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71,763,000.00
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50,989,000.00
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
136,240,000.00
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,716,200.00
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33,023,000.00
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59,017,000.00
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86,021,000.00
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
110,860,000.00
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.47%. Comparing base (d01eb3c) to head (5e885d7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crypto-ffi/src/generic/mod.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   75.47%   75.47%           
=======================================
  Files         107      107           
  Lines       19916    19916           
=======================================
  Hits        15031    15031           
  Misses       4885     4885           
Files with missing lines Coverage Δ
crypto-ffi/src/generic/mod.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01eb3c...5e885d7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants