Tailwind theme create improvements #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally, we should validate the NPM version prior to generating the initial theme structure, as if it fails we have no way to reset the state which means that the user will not be able to "try again" as the dir already exists. |
LukeTowers
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old css/js scaffold files and adds better error reporting for creating a vite theme.
This includes missing / outdated NPM detection:
And feedback to the user if any command should fail:
I also added better support for extension, in the future we can look into adding mix support too via passing the processor here:
The new
npm:versioncommand will by default just report the version to the user, if you want to use it to test if the version is compatible with Winter you need to pass the--compatibleflag and check the exit code. See: