progwrp.lib for unbranded builds. #396
Replies: 24 comments
-
|
Known issue: #300 |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things How would I make the .lib from the .dll? EDIT: What about this: https://stackoverflow.com/questions/9360280/how-to-make-a-lib-file-when-have-a-dll-file-and-a-header-file |
Beta Was this translation helpful? Give feedback.
-
Just use dll2lib and so on. Your brain, and your hands ... And some small time.
yes, read this, do something.. and you have got something |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things OK will try. |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things Update: I was able to generate .lib and .exp files for it. Then I generated a .patch file by copying Supermium over the Chromium tree, then removed the Supermium branding and ungoogled patches. Now I am building, with the .lib placed in the //out/Release folder as well as //build/config (where it is picked up and applied to all build targets). Will let people know here whether I get a successful build or not, and whether it runs properly on Win XP. |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 thats Cool. I personally want to build Chromium not just to run on XP, but build on XP. And fixed Microsoft tools for that in the past. Are you use VS2015 to rebuild ? |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things No. Chromium must be built with 2019 or 2022. And uses functions only present in Windows 8.1 and above. Minimum is MSVS 2019 on Win 8.1/2012 R2. The amount of work to get it to compile on XP with MSVS 2015 would probably entail more work than the whole of the changes in Supermium to begin with. Not to mention that XP era hardware, even Ivy Bridge or AMD FX, would take ages to compile Chromium. Compiling it on my overclocked Ryzen 3800XT already takes 3-4 hours. Even @win32ss Is using Win 10 LTSB + MSVS 2022 to make his releases. |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 , Ok , I can try to fix VS2019 to run on XP also, as its done by me for previous VS versions. Because we need only command-line tools. I have not so power machine, just Intel Core i3 3500. And I use XP with 16 Gb memory. If buid will take 8 hours instead of 4, -- not a problem for me at this time. Even 12 or 24. This is not everyday job. I not plan to rebuild it everyday. About SSE3 optimizations ... I can live without it here. :) Because this is just a browser, not a game core. And video hardware acceleration must be executed on graphics card. |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things Memory is OK. There is no such model as 3500 in ivy bridge > https://en.wikipedia.org/wiki/Ivy_Bridge_(microarchitecture)#Desktop_processors are you sure it isn't something else? Compiling on the top of the line Haswell CPU the 4790K, takes about 6 hours. Your setup can compile it fine, but yeah, expect it to take 8+ hours or more. |
Beta Was this translation helpful? Give feedback.
-
|
Intel Core i3-3250 3.5 GHz. I'm tryed to rebuild the old Firefox clones.. Or Windows sources in the past.. Reconfiguring and fixing things takes more-more time then compiling |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things Ahh, top of the line 2 core 4 thread i3. Will probably perform as well as a top of the line 4 core 1st gen "nahlem" CPU. And lol yeah, sometimes it does. |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 , in any case I dont care about this. Its not separate build machine, but my usual dev environment, which is enought for me. What about compiling your Thorium on you side ? Is it was successful ? Which features you are planned to add to this ? |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things The .lib I created doesn't work. Trying to run on XP yields AcquireSRWLockExclusive was not found in KERNEL32.dll. This is supposed to be handled by progwrp.dll and using binary grep the string was found in the dll. This is what I did when making a custom vanilla Chromium patch for Windows 7 to base Thorium-Win7 on. On windows 7 it crashes. However, if I remove the progwrp.lib from the linker flags, and change PSAPI_VERSION back to 2 (the normal value for win7+), then it works fine, but of course not on XP. I think @win32ss supplying the .lib will be the only way to build for XP. |
Beta Was this translation helpful? Give feedback.
-
I compiled it according to your method, and after running Win7, it crashed |
Beta Was this translation helpful? Give feedback.
-
|
@longyixiao See here. This is all you need to do to make a Win7 build > main...Alex313031:cr-win7:main |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 The compilation has been successful and can be run on Win7. However, watching videos can cause the CPU to surge to 100% |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 Do you have this situation on your end |
Beta Was this translation helpful? Give feedback.
-
|
@longyixiao Can you give me a specific video link where this is happening. Videos on my website, and on youtube are playing fine with no CPU spikes. |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 Sorry, that's not the problem anymore. I also have this issue with the original Chrome browser |
Beta Was this translation helpful? Give feedback.
-
|
@longyixiao Oh OK. BTW, if you want to make a windows vista build, you should keep everything the same, except remove progwrp.lib, which is only used for Win XP. But you must revert the other stuff back, particularly PSAPI_VERSION, since Vista and below only support ver. 1 |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things @longyixiao Lookie here y'all! > https://github.com/win32ss/supermium?tab=readme-ov-file#supermium The latest .zips have the .lib files inside them!!! Time to drop everything and work on an XP/Vista Thorium build! Thanks, @win32ss |
Beta Was this translation helpful? Give feedback.
-
I think time to fix the bugs, and do it more stable on XP. )) |
Beta Was this translation helpful? Give feedback.
-
|
@IDA-RE-things I'm just excited to get it working on XP (which I just did!). IDK how much I could contribute to fixing XP-specific bugs. |
Beta Was this translation helpful? Give feedback.
-
|
@Alex313031 , |
Beta Was this translation helpful? Give feedback.
-
@win32ss Hi again. Im trying to make a .patch file based on your source to make an unbranded build of Chromium for NT 5.x, i.e. without Supermium branding and without ungoogled patches. However, progwrp.lib is needed for compilation (not just the .dll).
Could you add that to the tree, or make it open source, (or maybe not open source, but just make the .lib and .dll available for usage). If none of that's possible or you don't wish to do so (which I wouldn't blame you for, it's a unique piece of work that probably took alot of time, and which you will probably use in other products from your new company), would you be willing to share it with me under an NDA, just so that I could make builds of Chromium (and possibly Thorium) for Win XP. My mom is a lawyer, so it happens, and she could draft up a contract of some sort basically saying that I wont distribute or share anything related to it except the final .dll in the finished browser.
Beta Was this translation helpful? Give feedback.
All reactions